You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/06 22:56:00 UTC
[jira] [Work logged] (BEAM-9557) Error setting processing time
timers near end-of-window
[ https://issues.apache.org/jira/browse/BEAM-9557?focusedWorklogId=417256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417256 ]
ASF GitHub Bot logged work on BEAM-9557:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 22:55
Start Date: 06/Apr/20 22:55
Worklog Time Spent: 10m
Work Description: amaliujia commented on issue #11226: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11226#issuecomment-610078277
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 417256)
Time Spent: 7h (was: 6h 50m)
> Error setting processing time timers near end-of-window
> -------------------------------------------------------
>
> Key: BEAM-9557
> URL: https://issues.apache.org/jira/browse/BEAM-9557
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Steve Niemitz
> Assignee: Reuven Lax
> Priority: Critical
> Fix For: 2.20.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Previously, it was possible to set a processing time timer past the end of a window, and it would simply not fire.
> However, now, this results in an error:
> {code:java}
> java.lang.IllegalArgumentException: Attempted to set event time timer that outputs for 2020-03-19T18:01:35.000Z but that is after the expiration of window 2020-03-19T17:59:59.999Z
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> org.apache.beam.runners.dataflow.worker.repackaged.org.apache.beam.runners.core.SimpleDoFnRunner$TimerInternalsTimer.setAndVerifyOutputTimestamp(SimpleDoFnRunner.java:1011)
> org.apache.beam.runners.dataflow.worker.repackaged.org.apache.beam.runners.core.SimpleDoFnRunner$TimerInternalsTimer.setRelative(SimpleDoFnRunner.java:934)
> <snip>.processElement(???.scala:187)
> {code}
>
> I think the regression was introduced in commit a005fd765a762183ca88df90f261f6d4a20cf3e0. Also notice that the error message is wrong, it says that "event time timer" but the timer is in the processing time domain.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)