[jira] [Commented] (CB-9834) Hooks in crosswalk plugin do not work any more because we moved ConfigParser

["Nikhil Khandelwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965896#comment-14965896 ] 

Nikhil Khandelwal commented on CB-9834:
---------------------------------------

[~vladimir.kotikov] Thoughts on how to fix this. The specific hook that breaks is here: https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/blob/master/hooks/update_config.js#L8 

One hacky way to fix this would be to have the requireCordovaModule re-direct to the moved location for the respective modules automatically for this short term. 

In the longer term, we should publish cordova-common and file a GitHub issue for the crosswalk plugin and any other plugins to use that.


> Hooks in crosswalk plugin do not work any more because we moved ConfigParser
> ----------------------------------------------------------------------------
>
>                 Key: CB-9834
>                 URL: https://issues.apache.org/jira/browse/CB-9834
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Nikhil Khandelwal
>            Priority: Critical
>
> Get the master version of cordova-lib and cordova-cli and create a cordova project.
> Add the cross-walk plugin: cordova plugin add cordova-plugin-crosswalk-webview
> Fetching plugin "cordova-plugin-crosswalk-webview@^1.2.0" via npm
> Installing "cordova-plugin-crosswalk-webview" for android
> Failed to install 'cordova-plugin-crosswalk-webview':Error: Cannot find module 'cordova-lib/src/configparser/ConfigParser'
>     at Function.Module._resolveFilename (module.js:336:15)
>     at Function.Module._load (module.js:286:25)
>     at Module.require (module.js:365:17)
>     at require (module.js:384:17)
>     at Context.requireCordovaModule (D:\cordova\cordova-lib\cordova-lib\src\hooks\Context.js:48:12)
>     at module.exports (d:\apps\test\plugins\cordova-plugin-crosswalk-webview\hooks\after_plugin_install\000-shared_mode_special.js:9:32)
>     at runScriptViaModuleLoader (D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:151:18)
>     at runScript (D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:129:16)
>     at D:\cordova\cordova-lib\cordova-lib\src\hooks\HooksRunner.js:114:20
>     at _fulfilled (D:\cordova\cordova-lib\cordova-lib\node_modules\q\q.js:787:54)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org