[GitHub] [iotdb] irvine0109 commented on a change in pull request #3105: [IoTDB-1331] Add transformPath for CMManger

[GitBox <gi...@apache.org>]

irvine0109 commented on a change in pull request #3105:
URL: https://github.com/apache/iotdb/pull/3105#discussion_r623626614



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -265,6 +266,20 @@ public IMeasurementSchema getSeriesSchema(PartialPath fullPath) throws MetadataE
     return super.getSeriesSchema(fullPath, getMeasurementMNode(fullPath));
   }
 
+  /**
+   * Transform the PartialPath to VectorPartialPath if it is a sub sensor of one vector. otherwise,
+   * we don't change it.
+   */
+  @Override
+  public PartialPath transformPath(PartialPath partialPath) throws MetadataException {
+    MeasurementMNode node = getMeasurementMNode(partialPath);

Review comment:
       > I think `getMeasurementMNode` should be consist with `getNodeByPath`...
   To be consistent, do you mean that method `MManager.getNodeByPath()` should have the function of getting schema both locally and remotely? Or method `CMManager.getMeasurementMNode()`should only have the function of getting schema locally?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org