You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2015/04/08 18:41:11 UTC
incubator-zeppelin git commit: Fix header for directive template
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 669d408dc -> 8b8edc244
Fix header for directive template
Change the header position in the directive template.
When the header is at the top level it counts as a node root in the DOM and throw an error in angularjs.
src: https://docs.angularjs.org/error/$compile/tplrt
This issue as been fixed in Angularjs 1.4 beta, so we won't have problems in the future (currently 1.3.8)
Author: Damien Corneau <co...@gmail.com>
Closes #29 from corneadoug/fix/licenseInDirectivesViews and squashes the following commits:
deb5a61 [Damien Corneau] Fix header for directive template
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/8b8edc24
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/8b8edc24
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/8b8edc24
Branch: refs/heads/master
Commit: 8b8edc2442e5582173436a7e8c20d39f8ea408b0
Parents: 669d408
Author: Damien Corneau <co...@gmail.com>
Authored: Tue Apr 7 16:00:35 2015 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Thu Apr 9 01:41:07 2015 +0900
----------------------------------------------------------------------
zeppelin-web/app/views/popover-html-unsafe-popup.html | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/8b8edc24/zeppelin-web/app/views/popover-html-unsafe-popup.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/app/views/popover-html-unsafe-popup.html b/zeppelin-web/app/views/popover-html-unsafe-popup.html
index e36b041..f537aee 100644
--- a/zeppelin-web/app/views/popover-html-unsafe-popup.html
+++ b/zeppelin-web/app/views/popover-html-unsafe-popup.html
@@ -1,9 +1,10 @@
+<div class="popover {{placement}}" ng-class="{ in: isOpen(), fade: animation() }">
<!--
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
+http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
@@ -11,12 +12,10 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-<div class="popover {{placement}}" ng-class="{ in: isOpen(), fade: animation() }">
<div class="arrow"></div>
<div class="popover-inner">
- <h3 class="popover-title" ng-bind="title" ng-show="title"></h3>
- <div class="popover-content" bind-html-unsafe="content"></div>
+ <h3 class="popover-title" ng-bind="title" ng-show="title"></h3>
+ <div class="popover-content" bind-html-unsafe="content"></div>
</div>
</div>