[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

[Tibor17 <gi...@git.apache.org>]

Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/127#discussion_r82527079
  
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java ---
    @@ -76,7 +76,7 @@ public TestSetRunListener( ConsoleReporter consoleReporter, FileReporter fileRep
                                    StatisticsReporter statisticsReporter, boolean trimStackTrace,
                                    boolean isPlainFormat, boolean briefOrPlainFormat )
         {
    -        this.consoleReporter = consoleReporter;
    +        this.consoleReporter = consoleReporter != null ? consoleReporter : new NullConsoleReporter();
    --- End diff --
    
    All of these classes are in `surefire-common` project. Therefor it would be nice not to create a new object 
    `new NullConsoleReporter()` but instead keep it as static final constant in abstract Factory in surefire-common.
    This would mean that such null-check may be embedded in the factory, e.g. `buildConsoleReporter()`. I would say that the caller should pass non-null consistent object into this class `TestSetRunListener` via constructor and the called class should not make any guess about it (means if == null => guess hide the error). If we accepted such paradigm then all such occurrences in this PR would have to change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org