You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/09 17:41:51 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

julianhyde commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r301711715
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
 ##########
 @@ -303,6 +303,10 @@ public RelNode createAggregate(RelNode input,
   public interface FilterFactory {
     /** Creates a filter. */
     RelNode createFilter(RelNode input, RexNode condition);
+
+    /** Creates a filter. */
+    RelNode createFilter(RelNode input, RexNode condition,
 
 Review comment:
   I've added comments in the JIRA case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services