You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/03/29 14:27:06 UTC
[jira] [Created] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Popup close link not working in wicket examples linkomatic page
---------------------------------------------------------------
Key: WICKET-3571
URL: https://issues.apache.org/jira/browse/WICKET-3571
Project: Wicket
Issue Type: Bug
Components: wicket-examples
Affects Versions: 1.5-RC3
Environment: IE 8, can't reproduce on Chrome
Reporter: Pedro Santos
Assignee: Pedro Santos
Priority: Minor
To reproduce:
visit http://localhost:8080/linkomatic/home
click "Click this button for a popup"
click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020831#comment-13020831 ]
Juergen Donnerstag commented on WICKET-3571:
--------------------------------------------
thanks Attila. I fixed the test/header already
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: fix-WICKET-3571-2.patch, fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag reopened WICKET-3571:
----------------------------------------
Ahh, I see. I changed it because the license header test failed. Obviously we need to fixed the test instead.
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: fix-WICKET-3571-2.patch, fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3571.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC4
thanks a lot
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.5-RC4
>
> Attachments: fix-WICKET-3571-2.patch, fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020959#comment-13020959 ]
Attila Király commented on WICKET-3571:
---------------------------------------
I might miss something because closing popups in IE 6, 8, 9 does not work for me with the current trunk. The opening <html> is after the apache license comment which is A Tag Too Far for IE. So I would like to suggest to apply my second patch that moves the <html> to the first line of the page after the xml declaration. This makes both IE and the license header test happy.
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: fix-WICKET-3571-2.patch, fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3571:
----------------------------------
Attachment: fix-WICKET-3571-2.patch
I see my previous patch was applied and then reverted because it failed the Apache license header test. This means that this issue is still valid.
A am attaching a new patch that fixes the issue and also passes the license header test.
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: fix-WICKET-3571-2.patch, fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3571.
----------------------------------------
Resolution: Fixed
Assignee: Juergen Donnerstag (was: Pedro Santos)
thanks a lot
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3571) Popup close link not working in
wicket examples linkomatic page
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3571:
----------------------------------
Attachment: fix-WICKET-3571.patch
Attaching patch that fixes the issue. Tested with IE 6, 8, 9.
> Popup close link not working in wicket examples linkomatic page
> ---------------------------------------------------------------
>
> Key: WICKET-3571
> URL: https://issues.apache.org/jira/browse/WICKET-3571
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC3
> Environment: IE 8, can't reproduce on Chrome
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Minor
> Attachments: fix-WICKET-3571.patch
>
>
> To reproduce:
> visit http://localhost:8080/linkomatic/home
> click "Click this button for a popup"
> click "close" link
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira