You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "Zowalla, Richard" <ri...@hs-heilbronn.de> on 2021/03/04 11:35:04 UTC

CI Build Environment ISO-8859-1 versus UTF-8

Hi,

it seems our CI environments suffers from using the default platform
encoding 'ISO-8859-1':

[ERROR] Failures: 
[ERROR]   TomEEJsonbProviderTest.run:82 expected:<{"date":"M[�]r-
2021","fieldAccess...> but was:<{"date":"M[ä]r-2021","fieldAccess...>


The failing test 'TomEEJsonbProviderTest' tests a German configuration
for date formatting. As we are in March (DE: März) now, it contains the
German umlaut "ä", which leads to the failing test.

Might be worth adding

-Dfile.encodig=UTF-8

to the build options? Wdyt?


Gruss
Richard




-------- Weitergeleitete Nachricht --------
Von: Apache Jenkins Server <je...@builds.apache.org>
Antwort an: dev@tomee.apache.org
An: commits@tomee.apache.org
Betreff: Jenkins build became unstable:  TomEE » master-build-quick » 
TomEE :: Server :: CXF RS #49
Datum: Thu, 04 Mar 2021 11:12:28 +0000

> See <
> https://ci-builds.apache.org/job/Tomee/job/master-build-quick/org.apache.tomee$openejb-cxf-rs/49/display/redirect
> >
> 
-- 
Richard Zowalla, M.Sc.
Research Associate, PhD Student | Medical Informatics

Hochschule Heilbronn – University of Applied Sciences
Max-Planck-Str. 39 
D-74081 Heilbronn 
phone: +49 7131 504 6791
mail: richard.zowalla@hs-heilbronn.de
web: https://www.mi.hs-heilbronn.de/ 

Re: CI Build Environment ISO-8859-1 versus UTF-8

Posted by Jonathan Gallimore <jo...@gmail.com>.
I'm ok with either. I'd probably lean towards (b) myself if that's the only
affected module.

Jon

On Fri, Mar 5, 2021 at 8:37 AM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:

> Hi,
>
> I updated the Jenkins CI config, which didnt help a lot as the tests
> seem to be executed in a separate jvm.
>
> It might be necessary to add the property also to the surfire plugin
> configuration via <argLine> to ensure that the tests are executed
> with UTF-8 instead of ISO-8859-1 as default charset.
>
> I see two options
>
> (a) Update the <argLine> of the surefire plugin to use a
> -Dfile.encoding=UTF-8
>
> (b) Override the plugin config for surefire only in the related module
> "openejb-cxf-rs".
>
> If we have a common opinion on it, I can create a related JIRA.
>
> Gruss
> Richard
>
>
> Am Donnerstag, den 04.03.2021, 12:37 +0000 schrieb Zowalla, Richard:
> > Yup, will do.
> >
> > Am Donnerstag, den 04.03.2021, 12:05 +0000 schrieb Jonathan
> > Gallimore:
> > > Sounds good. Are you able to change it?
> > >
> > > Jon
> > >
> > > On Thu, Mar 4, 2021 at 11:35 AM Zowalla, Richard <
> > > richard.zowalla@hs-heilbronn.de> wrote:
> > >
> > > > Hi,
> > > >
> > > > it seems our CI environments suffers from using the default
> > > > platform
> > > > encoding 'ISO-8859-1':
> > > >
> > > > [ERROR] Failures:
> > > > [ERROR]   TomEEJsonbProviderTest.run:82 expected:<{"date":"M[�]r-
> > > > 2021","fieldAccess...> but was:<{"date":"M[ä]r-
> > > > 2021","fieldAccess...>
> > > >
> > > >
> > > > The failing test 'TomEEJsonbProviderTest' tests a German
> > > > configuration
> > > > for date formatting. As we are in March (DE: März) now, it
> > > > contains
> > > > the
> > > > German umlaut "ä", which leads to the failing test.
> > > >
> > > > Might be worth adding
> > > >
> > > > -Dfile.encodig=UTF-8
> > > >
> > > > to the build options? Wdyt?
> > > >
> > > >
> > > > Gruss
> > > > Richard
> > > >
> > > >
> > > >
> > > >
> > > > -------- Weitergeleitete Nachricht --------
> > > > Von: Apache Jenkins Server <je...@builds.apache.org>
> > > > Antwort an: dev@tomee.apache.org
> > > > An: commits@tomee.apache.org
> > > > Betreff: Jenkins build became unstable:  TomEE » master-build-
> > > > quick
> > > > »
> > > > TomEE :: Server :: CXF RS #49
> > > > Datum: Thu, 04 Mar 2021 11:12:28 +0000
> > > >
> > > > > See <
> > > > >
> > > >
> https://ci-builds.apache.org/job/Tomee/job/master-build-quick/org.apache.tomee$openejb-cxf-rs/49/display/redirect
> > >
>

Re: CI Build Environment ISO-8859-1 versus UTF-8

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Hi,

I updated the Jenkins CI config, which didnt help a lot as the tests
seem to be executed in a separate jvm. 

It might be necessary to add the property also to the surfire plugin
configuration via <argLine> to ensure that the tests are executed
with UTF-8 instead of ISO-8859-1 as default charset. 

I see two options

(a) Update the <argLine> of the surefire plugin to use a
-Dfile.encoding=UTF-8 

(b) Override the plugin config for surefire only in the related module
"openejb-cxf-rs". 

If we have a common opinion on it, I can create a related JIRA.

Gruss
Richard


Am Donnerstag, den 04.03.2021, 12:37 +0000 schrieb Zowalla, Richard:
> Yup, will do.
> 
> Am Donnerstag, den 04.03.2021, 12:05 +0000 schrieb Jonathan
> Gallimore:
> > Sounds good. Are you able to change it?
> > 
> > Jon
> > 
> > On Thu, Mar 4, 2021 at 11:35 AM Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> > 
> > > Hi,
> > > 
> > > it seems our CI environments suffers from using the default
> > > platform
> > > encoding 'ISO-8859-1':
> > > 
> > > [ERROR] Failures:
> > > [ERROR]   TomEEJsonbProviderTest.run:82 expected:<{"date":"M[�]r-
> > > 2021","fieldAccess...> but was:<{"date":"M[ä]r-
> > > 2021","fieldAccess...>
> > > 
> > > 
> > > The failing test 'TomEEJsonbProviderTest' tests a German
> > > configuration
> > > for date formatting. As we are in March (DE: März) now, it
> > > contains
> > > the
> > > German umlaut "ä", which leads to the failing test.
> > > 
> > > Might be worth adding
> > > 
> > > -Dfile.encodig=UTF-8
> > > 
> > > to the build options? Wdyt?
> > > 
> > > 
> > > Gruss
> > > Richard
> > > 
> > > 
> > > 
> > > 
> > > -------- Weitergeleitete Nachricht --------
> > > Von: Apache Jenkins Server <je...@builds.apache.org>
> > > Antwort an: dev@tomee.apache.org
> > > An: commits@tomee.apache.org
> > > Betreff: Jenkins build became unstable:  TomEE » master-build-
> > > quick 
> > > »
> > > TomEE :: Server :: CXF RS #49
> > > Datum: Thu, 04 Mar 2021 11:12:28 +0000
> > > 
> > > > See <
> > > > 
> > > https://ci-builds.apache.org/job/Tomee/job/master-build-quick/org.apache.tomee$openejb-cxf-rs/49/display/redirect
> > 

Re: CI Build Environment ISO-8859-1 versus UTF-8

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Yup, will do.

Am Donnerstag, den 04.03.2021, 12:05 +0000 schrieb Jonathan Gallimore:
> Sounds good. Are you able to change it?
> 
> Jon
> 
> On Thu, Mar 4, 2021 at 11:35 AM Zowalla, Richard <
> richard.zowalla@hs-heilbronn.de> wrote:
> 
> > Hi,
> > 
> > it seems our CI environments suffers from using the default
> > platform
> > encoding 'ISO-8859-1':
> > 
> > [ERROR] Failures:
> > [ERROR]   TomEEJsonbProviderTest.run:82 expected:<{"date":"M[�]r-
> > 2021","fieldAccess...> but was:<{"date":"M[ä]r-
> > 2021","fieldAccess...>
> > 
> > 
> > The failing test 'TomEEJsonbProviderTest' tests a German
> > configuration
> > for date formatting. As we are in March (DE: März) now, it contains
> > the
> > German umlaut "ä", which leads to the failing test.
> > 
> > Might be worth adding
> > 
> > -Dfile.encodig=UTF-8
> > 
> > to the build options? Wdyt?
> > 
> > 
> > Gruss
> > Richard
> > 
> > 
> > 
> > 
> > -------- Weitergeleitete Nachricht --------
> > Von: Apache Jenkins Server <je...@builds.apache.org>
> > Antwort an: dev@tomee.apache.org
> > An: commits@tomee.apache.org
> > Betreff: Jenkins build became unstable:  TomEE » master-build-quick 
> > »
> > TomEE :: Server :: CXF RS #49
> > Datum: Thu, 04 Mar 2021 11:12:28 +0000
> > 
> > > See <
> > > 
> > https://ci-builds.apache.org/job/Tomee/job/master-build-quick/org.apache.tomee$openejb-cxf-rs/49/display/redirect
> > --
> > Richard Zowalla, M.Sc.
> > Research Associate, PhD Student | Medical Informatics
> > 
> > Hochschule Heilbronn – University of Applied Sciences
> > Max-Planck-Str. 39
> > D-74081 Heilbronn
> > phone: +49 7131 504 6791
> > mail: richard.zowalla@hs-heilbronn.de
> > web: https://www.mi.hs-heilbronn.de/
> > 
-- 
Richard Zowalla, M.Sc.
Research Associate, PhD Student | Medical Informatics

Hochschule Heilbronn – University of Applied Sciences
Max-Planck-Str. 39 
D-74081 Heilbronn 
phone: +49 7131 504 6791
mail: richard.zowalla@hs-heilbronn.de
web: https://www.mi.hs-heilbronn.de/ 

Re: CI Build Environment ISO-8859-1 versus UTF-8

Posted by Jonathan Gallimore <jo...@gmail.com>.
Sounds good. Are you able to change it?

Jon

On Thu, Mar 4, 2021 at 11:35 AM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:

> Hi,
>
> it seems our CI environments suffers from using the default platform
> encoding 'ISO-8859-1':
>
> [ERROR] Failures:
> [ERROR]   TomEEJsonbProviderTest.run:82 expected:<{"date":"M[�]r-
> 2021","fieldAccess...> but was:<{"date":"M[ä]r-2021","fieldAccess...>
>
>
> The failing test 'TomEEJsonbProviderTest' tests a German configuration
> for date formatting. As we are in March (DE: März) now, it contains the
> German umlaut "ä", which leads to the failing test.
>
> Might be worth adding
>
> -Dfile.encodig=UTF-8
>
> to the build options? Wdyt?
>
>
> Gruss
> Richard
>
>
>
>
> -------- Weitergeleitete Nachricht --------
> Von: Apache Jenkins Server <je...@builds.apache.org>
> Antwort an: dev@tomee.apache.org
> An: commits@tomee.apache.org
> Betreff: Jenkins build became unstable:  TomEE » master-build-quick »
> TomEE :: Server :: CXF RS #49
> Datum: Thu, 04 Mar 2021 11:12:28 +0000
>
> > See <
> >
> https://ci-builds.apache.org/job/Tomee/job/master-build-quick/org.apache.tomee$openejb-cxf-rs/49/display/redirect
> > >
> >
> --
> Richard Zowalla, M.Sc.
> Research Associate, PhD Student | Medical Informatics
>
> Hochschule Heilbronn – University of Applied Sciences
> Max-Planck-Str. 39
> D-74081 Heilbronn
> phone: +49 7131 504 6791
> mail: richard.zowalla@hs-heilbronn.de
> web: https://www.mi.hs-heilbronn.de/
>