You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "chengyouling (via GitHub)" <gi...@apache.org> on 2024/01/04 02:27:03 UTC
[PR] [#4184] Router add some log for deal problem. [servicecomb-java-chassis]
chengyouling opened a new pull request, #4185:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4185
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4184] Router add some log for deal problem. [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on code in PR #4185:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4185#discussion_r1441520341
##########
governance/src/main/java/org/apache/servicecomb/router/RouterFilter.java:
##########
@@ -58,7 +58,7 @@ public <T> List<T> getFilteredListOfServers(List<T> list,
PolicyRuleItem invokeRule = routerRuleMatcher.match(targetServiceName, extractor);
if (invokeRule == null) {
- LOGGER.debug("route management match rule failed");
+ LOGGER.warn("route management hava no rule matched service {}", targetServiceName);
Review Comment:
Too many logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4184] Router add some log for deal problem. [servicecomb-java-chassis]
Posted by "chengyouling (via GitHub)" <gi...@apache.org>.
chengyouling commented on code in PR #4185:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4185#discussion_r1441700819
##########
governance/src/main/java/org/apache/servicecomb/router/RouterFilter.java:
##########
@@ -58,7 +58,7 @@ public <T> List<T> getFilteredListOfServers(List<T> list,
PolicyRuleItem invokeRule = routerRuleMatcher.match(targetServiceName, extractor);
if (invokeRule == null) {
- LOGGER.debug("route management match rule failed");
+ LOGGER.warn("route management hava no rule matched service {}", targetServiceName);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4184] Router add some log for deal problem. [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4185:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4184] Router add some log for deal problem. [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4185:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4185#issuecomment-1877064545
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `2 lines` in your changes are missing coverage. Please review.
> :exclamation: No coverage uploaded for pull request base (`master@492b8d0`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit).
> :exclamation: Current head b8d72e5 differs from pull request most recent head 2a4e6a8. Consider uploading reports for the commit 2a4e6a8 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/servicecomb/router/cache/RouterRuleCache.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcm91dGVyL2NhY2hlL1JvdXRlclJ1bGVDYWNoZS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4185 +/- ##
=========================================
Coverage ? 44.39%
Complexity ? 5398
=========================================
Files ? 1382
Lines ? 34341
Branches ? 3326
=========================================
Hits ? 15246
Misses ? 17860
Partials ? 1235
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4185?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org