You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/02/14 10:29:46 UTC
Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java db169d0
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
intg/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java b368515
intg/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java f58b1ff
intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e882473
intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 8538b80
intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f94fec4
intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java ec5f75a
intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java a7ada38
intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java aaf4a6a
intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 1b3bbc7
intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java b3cbe72
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 2d71d41
intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 64fc3e3
intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java c2b5eb4
intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 7eefcc2
intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java dcee3fe
intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java fb4a183
intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java 2b15ba0
intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c4c7611
intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java a37dd46
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e493345
webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java 2b71489
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java 6d8e3ae
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java 2b70c5e
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/#review165790
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java (line 221)
<https://reviews.apache.org/r/56651/#comment237645>
AtlasObjectId is not a valid value for AtlasEntity. Please review and update.
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java (line 250)
<https://reviews.apache.org/r/56651/#comment237646>
AtlasObjectId is not a valid value for AtlasEntity. Please review and update.
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 227)
<https://reviews.apache.org/r/56651/#comment237647>
Replace line #227 and #202 with:
attributes = AtlasTypeUtil.toStructAttributes((Map)obj);
- Madhan Neethiraj
On Feb. 16, 2017, 12:17 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56651/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 12:17 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1554
> https://issues.apache.org/jira/browse/ATLAS-1554
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45b12e3
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
> intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
> repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
>
> Diff: https://reviews.apache.org/r/56651/diff/
>
>
> Testing
> -------
>
> mvn clean package - Build succeeded with all tests passed.
> mvn clean install - usual failure in webapp module - TaxonomyServiceTest
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/#review165814
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 16, 2017, 1:58 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56651/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 1:58 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1554
> https://issues.apache.org/jira/browse/ATLAS-1554
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45b12e3
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
> intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
> repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
>
> Diff: https://reviews.apache.org/r/56651/diff/
>
>
> Testing
> -------
>
> mvn clean package - Build succeeded with all tests passed.
> mvn clean install - usual failure in webapp module - TaxonomyServiceTest
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 5:58 p.m.)
Review request for atlas.
Changes
-------
addressed review comments.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45b12e3
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
mvn clean package - Build succeeded with all tests passed.
mvn clean install - usual failure in webapp module - TaxonomyServiceTest
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 4:17 p.m.)
Review request for atlas.
Changes
-------
* Updated AtlasEntityType methods to skip AtlasObjectId validation.
* Refactored AtlasStructType methods - isValidValueForUpdate(), getNormalizedValueForUpdate() and validateValueForUpdate()
* Moved ValidateAndNormalize step after discovery and resolveReference stage.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45b12e3
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
mvn clean package - Build succeeded with all tests passed.
mvn clean install - usual failure in webapp module - TaxonomyServiceTest
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/#review165728
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java (line 266)
<https://reviews.apache.org/r/56651/#comment237579>
Now that AtlasObjectIdType is used for entity-type attributes, "AtlasObjectId" should no more be a valid value for AtlasEntityType.
Please update AtlasEntityType methods to recoginize only AtlasEntity and Map type objects as valid value.
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 223)
<https://reviews.apache.org/r/56651/#comment237581>
for update validation, the iteration should be on the attributes of the value, instead of the attributes defined in the type. i.e. value might have fewer attributes.
for (Map.Entry<String, Object> e : structObj.getAttributes()) {
String attrName = e.key();
Object attrValue = e.value();
if (!isAssignableValueForUpdate(attrValue, attrName)) {
return false;
}
}
Please review validateValueForUpdate() and normalizeAttributeValuesForUpdate() as well.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java (line 290)
<https://reviews.apache.org/r/56651/#comment237583>
calling \*ForUpdate() for all entities during partial-update may not work..given that some entities referenced by the updated entity might get created. In that case, the created entities should be validated 'for create'.
For example, update hive_table.columns attribute with addition of few columns.
Please review this logic. Perhaps discovery and validate should be split into 2 different steps.
- discovery
- resolve
- validate
validate() step should call *ForUpdate() only on entities that already exist.
- Madhan Neethiraj
On Feb. 15, 2017, 8:42 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56651/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:42 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1554
> https://issues.apache.org/jira/browse/ATLAS-1554
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 74acfdc
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
> intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
> repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
>
> Diff: https://reviews.apache.org/r/56651/diff/
>
>
> Testing
> -------
>
> mvn clean package - Build succeeded with all tests passed.
> mvn clean install - usual failure in webapp module - TaxonomyServiceTest
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 12:42 a.m.)
Review request for atlas.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 74acfdc
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
mvn clean package - Build succeeded with all tests passed.
mvn clean install - usual failure in webapp module - TaxonomyServiceTest
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 12:39 a.m.)
Review request for atlas.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 74acfdc
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java.orig PRE-CREATION
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing (updated)
-------
mvn clean package - Build succeeded with all tests passed.
mvn clean install - usual failure in webapp module - TaxonomyServiceTest
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 12:38 a.m.)
Review request for atlas.
Changes
-------
* added implementation of isValidValueForUpdate(), getNormalizedValueForUpdate() and validateValueForUpdate() for array and map types.
* additional test case to test partial updates on array of entities (columns)
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 74acfdc
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java.orig PRE-CREATION
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing (updated)
-------
mvn clean package - Build succeeded will all tests passed.
mvn clean install - usual failiure in webapp modules TaxonomyServiceTest
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 5:54 p.m.)
Review request for atlas.
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e493345
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
Ran all unit tests
Thanks,
Sarath Subramanian
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/#review165600
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java (line 269)
<https://reviews.apache.org/r/56651/#comment237460>
This should call isValidValueForUpdate() on each element in the array - similar to AtlasArrayType.isValidValue().
Same for getNormalizedValueForUpdate() and validateValueForUpdate().
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java (line 73)
<https://reviews.apache.org/r/56651/#comment237464>
default implementation of these methods should be in AtlasType, so that only the types that need to implement a different behavior would override.
- Madhan Neethiraj
On Feb. 14, 2017, 11:40 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56651/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 11:40 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1554
> https://issues.apache.org/jira/browse/ATLAS-1554
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
> intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java db169d0
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1
> intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
> intg/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java b368515
> intg/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java f58b1ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
> repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e493345
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
>
> Diff: https://reviews.apache.org/r/56651/diff/
>
>
> Testing
> -------
>
> Ran all unit tests
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for
entity partial update
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 3:40 p.m.)
Review request for atlas.
Changes
-------
* updated model with new methods - isValidValueForUpdate(), getNormalizedValueForUpdate() and validateValueForUpdate() for partial update validate/normalize operations
Bugs: ATLAS-1554
https://issues.apache.org/jira/browse/ATLAS-1554
Repository: atlas
Description
-------
Add REST endpoints to enable partial update of entity using unique attributes and implement the same.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java f839328
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a9a4a10
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java db169d0
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 39442f1
intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf
intg/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java b368515
intg/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java f58b1ff
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java d95b3f9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java d707bbd
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e493345
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7
Diff: https://reviews.apache.org/r/56651/diff/
Testing
-------
Ran all unit tests
Thanks,
Sarath Subramanian