[PATCH] fix kwallet-related crash when solving conflicts

[Lekensteyn <le...@gmail.com>]

Hi,

I experienced a segfault when trying to resolve a conflict while updating:
Conflict discovered in 'somefile'.
Select: (p) postpone, (df) diff-full, (e) edit,
        (mc) mine-conflict, (tc) theirs-conflict,
        (s) show all options: l
Process '/path/to/shell-script/merge-cmd' failed (exitwhy 6)

Further debugging revealed that a child process of svn segfaults and that this 
happens because of misuse of apr_pool_cleanup_register. That function does not 
accept null helpers. I've grepped the svn repo and the kwallet auth code is 
the only place where this error occurs.

Please see the attached patch, it was based on r1421011 and tested by applying 
it on top of 1.7.7.

Regards,
Peter

Re: [PATCH] fix kwallet-related crash when solving conflicts

[Ben Reser <be...@reser.org>]

On Wed, Dec 12, 2012 at 3:04 PM, Lekensteyn <le...@gmail.com> wrote:
> Further debugging revealed that a child process of svn segfaults and that this
> happens because of misuse of apr_pool_cleanup_register. That function does not
> accept null helpers. I've grepped the svn repo and the kwallet auth code is
> the only place where this error occurs.

Thanks for the complete bug report and patch.

Applied in r1421103.  FYI, since 1.7.8 is in the process of releasing
now this won't be included.