[GitHub] [iceberg] szehon-ho commented on a diff in pull request #7676: Spark-3.3: Harmonize RewriteDataFilesSparkAction

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #7676:
URL: https://github.com/apache/iceberg/pull/7676#discussion_r1201361740


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -331,24 +331,31 @@ private Result doExecuteWithPartialProgress(
       RewriteDataFilesCommitManager commitManager) {
     ExecutorService rewriteService = rewriteService();
 
-    // Start Commit Service
+    // start commit service
     int groupsPerCommit = IntMath.divide(ctx.totalGroupCount(), maxCommits, RoundingMode.CEILING);
     RewriteDataFilesCommitManager.CommitService commitService =
         commitManager.service(groupsPerCommit);
     commitService.start();
 
-    // Start rewrite tasks
+    Collection<FileGroupFailureResult> rewriteFailures = new ConcurrentLinkedQueue<>();

Review Comment:
   Looks like we are also backporting https://github.com/apache/iceberg/pull/7361 to Spark 3.3?  No problem with me, but we may want to note that in pr description in case some issues arise because of this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org