You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by db...@apache.org on 2015/08/12 01:53:59 UTC
svn commit: r1695412 - in
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6:
classfile/StackMapTableEntry.java generic/AnnotationEntryGen.java
generic/InstructionList.java
Author: dbrosius
Date: Tue Aug 11 23:53:59 2015
New Revision: 1695412
URL: http://svn.apache.org/r1695412
Log:
use StringBuilder correctly
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTableEntry.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/AnnotationEntryGen.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTableEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTableEntry.java?rev=1695412&r1=1695411&r2=1695412&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTableEntry.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTableEntry.java Tue Aug 11 23:53:59 2015
@@ -161,11 +161,11 @@ public final class StackMapTableEntry im
} else if (frame_type == Constants.SAME_LOCALS_1_STACK_ITEM_FRAME_EXTENDED) {
buf.append("SAME_LOCALS_1_STACK_EXTENDED");
} else if (frame_type >= Constants.CHOP_FRAME && frame_type <= Constants.CHOP_FRAME_MAX) {
- buf.append("CHOP "+(251-frame_type));
+ buf.append("CHOP ").append(String.valueOf(251-frame_type));
} else if (frame_type == Constants.SAME_FRAME_EXTENDED) {
buf.append("SAME_EXTENDED");
} else if (frame_type >= Constants.APPEND_FRAME && frame_type <= Constants.APPEND_FRAME_MAX) {
- buf.append("APPEND "+(frame_type-251));
+ buf.append("APPEND ").append(String.valueOf(frame_type-251));
} else if (frame_type == Constants.FULL_FRAME) {
buf.append("FULL");
} else {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/AnnotationEntryGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/AnnotationEntryGen.java?rev=1695412&r1=1695411&r2=1695412&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/AnnotationEntryGen.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/AnnotationEntryGen.java Tue Aug 11 23:53:59 2015
@@ -156,7 +156,7 @@ public class AnnotationEntryGen {
@Override
public String toString() {
StringBuilder s = new StringBuilder(32);
- s.append("AnnotationGen:[" + getTypeName() + " #" + evs.size() + " {");
+ s.append("AnnotationGen:[").append(getTypeName()).append(" #").append(evs.size()).append(" {");
for (int i = 0; i < evs.size(); i++) {
s.append(evs.get(i));
if (i + 1 < evs.size()) {
@@ -169,7 +169,7 @@ public class AnnotationEntryGen {
public String toShortString() {
StringBuilder s = new StringBuilder();
- s.append("@" + getTypeName() + "(");
+ s.append("@").append(getTypeName()).append("(");
for (int i = 0; i < evs.size(); i++) {
s.append(evs.get(i));
if (i + 1 < evs.size()) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java?rev=1695412&r1=1695411&r2=1695412&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java Tue Aug 11 23:53:59 2015
@@ -718,7 +718,7 @@ public class InstructionList implements
length--;
if (ih.hasTargeters()) { // Still got targeters?
target_vec.add(ih);
- buf.append(ih.toString(true) + " ");
+ buf.append(ih.toString(true)).append(" ");
ih.next = ih.prev = null;
} else {
ih.dispose();