You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/04 17:04:56 UTC

Re: Review Request 27564: SQOOP-1665: Misc Cleanup / rename lingering connection to link

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27564/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 8:04 a.m.)


Review request for Sqoop.


Summary (updated)
-----------------

SQOOP-1665: Misc Cleanup / rename lingering connection to link


Bugs: SQOOP-1665
    https://issues.apache.org/jira/browse/SQOOP-1665


Repository: sqoop-sqoop2


Description
-------

see JIRA
update java doc for destroyer
rename connection to link
clean up duplicate in destroyer committer, prefix it with SQoop to be consistent will all sqoop related classes for MR


Diffs
-----

  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java 03a1dec 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 32b5b1d 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java d2cf5e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java d31aa20 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 1148c4a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 8aad936 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java 972b555 
  spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java e2d98ca 

Diff: https://reviews.apache.org/r/27564/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27564: SQOOP-1665: Misc Cleanup / rename lingering connection to link

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27564/#review59773
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Nov. 4, 2014, 4:04 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27564/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 4:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1665
>     https://issues.apache.org/jira/browse/SQOOP-1665
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see JIRA
> update java doc for destroyer
> rename connection to link
> clean up duplicate in destroyer committer, prefix it with SQoop to be consistent will all sqoop related classes for MR
> 
> 
> Diffs
> -----
> 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java 03a1dec 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 32b5b1d 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java d2cf5e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java d31aa20 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 1148c4a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 8aad936 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java 972b555 
>   spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java e2d98ca 
> 
> Diff: https://reviews.apache.org/r/27564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>