Bug in Sequence.Tree.pathOf

[Chris Bartlett <cb...@googlemail.com>]

Hi,

Firstly, congratulations on the Graduation vote, and Pivot as a whole.
In the limited time I have had to play with PivotI am very impressed and
intend to work with it and contribute whenever I can.

Please find attached patch and code demonstrating a simple bug in
Sequence.Tree.pathOf(Sequence<T> sequence, T item).
This appears to have arisen because    Sequence.insert(T item, int index)
 and      Sequence.update(int index, T item)    have differing signatures.

I couldn't see any unit tests that cover this code, so have not run any
against it.

Chris

Re: Bug in Sequence.Tree.pathOf

[Todd Volkert <tv...@gmail.com>]

I'm really sorry for the run-around Chris (I hate beaurocracy), but legally,
we're not allowed to accept patches unless they're submitted via JIRA.  I've
created a ticket to track this issue (
https://issues.apache.org/jira/browse/PIVOT-351) -- can you please register
with JIRA and attach the zip file to that ticket.

Thanks!
-T

On Tue, Dec 1, 2009 at 5:55 AM, Chris Bartlett
<cb...@googlemail.com>wrote:

> Thanks for the info, Sandro.
> I looked for a FAQ or something with information about attachments, but
> didn't find one.
>
> Chris
>
> On Tue, Dec 1, 2009 at 5:42 PM, Sandro Martini <sa...@gmail.com>wrote:
>
>> Hi Chris,
>> thanks for the help, but please can you put the patch and the demo
>> code in a zip (or the mail server will drop it), and resend ?
>>
>> Thanks,
>> Sandro
>>
>
>

Re: Bug in Sequence.Tree.pathOf

[Chris Bartlett <cb...@googlemail.com>]

Thanks for the info, Sandro.
I looked for a FAQ or something with information about attachments, but
didn't find one.

Chris

On Tue, Dec 1, 2009 at 5:42 PM, Sandro Martini <sa...@gmail.com>wrote:

> Hi Chris,
> thanks for the help, but please can you put the patch and the demo
> code in a zip (or the mail server will drop it), and resend ?
>
> Thanks,
> Sandro
>

Re: Bug in Sequence.Tree.pathOf

[Sandro Martini <sa...@gmail.com>]

Hi Chris,
thanks for the help, but please can you put the patch and the demo
code in a zip (or the mail server will drop it), and resend ?

Thanks,
Sandro