You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/20 16:52:42 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
rhtyd opened a new pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605
This changes deb and rpm packaging to build the UI using npm and bundle
it in the `cloudstack-management` package and a new `cloudstack-ui`
package. The `cloudstack-ui` package will install the UI under
`/usr/share/cloudstack-ui/`. For both packages the config.json will not
be overridden on upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765475400
@rhtyd are there packages for testing ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562060003
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
> The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?
No, we should require it in the .spec and control file as a hard requirement. The build will fail without those, so it shouldn't even start to build.
The control and .spec file should exactly specify what is needed to build the packages. Without those dependencies the build should not initiate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768173680
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768266834
Aborted previous build job, kicking new one
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768183919
@weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561182249
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
@rhtyd this looks like a good point to be documented indeed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765214937
<b>Trillian test result (tid-3405)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30076 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4605-t3405-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 9.26 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764394815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764394815
<b>Trillian test result (tid-3403)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41304 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4605-t3403-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 123.82 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768873281
@weizhouapache we've two LGTMs, are you testing this? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764953794
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562557491
##########
File path: debian/control
##########
@@ -37,6 +37,11 @@ Description: CloudStack usage monitor
The CloudStack usage monitor provides usage accounting across the entire cloud for
cloud operators to charge based on usage parameters.
+Package: cloudstack-ui
+Architecture: all
+Depends: ${misc:Depends}
Review comment:
<pre>Depends: ${misc:Depends}</pre>
That might generate a long list of dependencies for the cloudstack-ui package which aren't needed at all.
Therefor we might want to compile the list manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764949964
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765794082
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764991882
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768267280
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763780910
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562508283
##########
File path: debian/cloudstack-ui.install
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+/usr/share/cloudstack-ui/config.json
Review comment:
Isn't this redundant as you also include the wildcard one line below?
In addition, config files should never be in /usr/share.
I would suggest:
- Create /etc/cloudstack/ui/config.json
- Symlink /usr/share/cloudstack-ui/config.json to /etc/cloudstack/ui/config.json
This way, when upgrading the DEB package will prompt before overriding any changes.
I suggest doing the same for the RPM packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765233342
<b>Trillian test result (tid-3406)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31862 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4605-t3406-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768292150
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764612964
@wido @GabrielBrascher doc PR raised here: https://github.com/apache/cloudstack-documentation/pull/182 and I've updated INSTALL.md in this PR
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562555224
##########
File path: debian/control
##########
@@ -37,6 +37,11 @@ Description: CloudStack usage monitor
The CloudStack usage monitor provides usage accounting across the entire cloud for
cloud operators to charge based on usage parameters.
+Package: cloudstack-ui
+Architecture: all
+Depends: ${misc:Depends}
Review comment:
Yes, this is based on the feedback on the ML - people may just want the UI to be say hosted by nginx. One way was to ship archive, the other to just introduce a new pkg that installs it at a specific location (not in cloudstack-managment pkg, which gets UI by default for backward compatibility)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561168505
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
Added, but that won't be satisfied automatically chances are somebody will install older version of nodejs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764779065
Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765450703
Re-ping @wido @GabrielBrascher @weizhouapache and others - pl review, addressed all comments.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764612964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768263067
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766589948
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763820109
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562209649
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
Added, but that won't be satisfied automatically chances are somebody will install older version of nodejs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766790290
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766589948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765000441
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562060003
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
> The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?
No, we should require it in the .spec and control file as a hard requirement. The build will fail without those, so it shouldn't even start to build.
The control and .spec file should exactly specify what is needed to build the packages. Without those dependencies the build should not initiate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561168505
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
The problem is tha nodejs lts may not be available in default/main repo of the distros. Should we document it on docs and install.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768173091
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768887207
> @weizhouapache we've two LGTMs, are you testing this? Thanks.
@rhtyd yes, tested ok. reviewing code. I will get back to you in 30 min.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768298678
@weizhouapache synced now http://download.cloudstack.org/testing/pr-4605/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768292590
@weizhouapache yes the pkgs just got rebuilt, I'll sync in next 15mins and ping you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765000831
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764946758
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768277183
> > @weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/
>
> @rhtyd thanks, I will test it.
@rhtyd
waiting for new packages on http://download.cloudstack.org/testing/pr-4605/debian/
```
Not Found
The requested URL was not found on this server.
Apache/2.4.18 (Ubuntu) Server at download.cloudstack.org Port 80
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766833247
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r563064692
##########
File path: debian/control
##########
@@ -37,6 +37,11 @@ Description: CloudStack usage monitor
The CloudStack usage monitor provides usage accounting across the entire cloud for
cloud operators to charge based on usage parameters.
+Package: cloudstack-ui
+Architecture: all
+Depends: ${misc:Depends}
Review comment:
Will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763819837
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561167971
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
Yes that adds a dependency much like jdk or mvn. I've added nodejs-12 (lts) in the container images that are used to build packages by blueorangutan. https://hub.docker.com/u/bhaisaab
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561168505
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765803639
Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768263761
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562678124
##########
File path: debian/cloudstack-ui.install
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+/usr/share/cloudstack-ui/config.json
Review comment:
I was thinking about conffiles but this is good idea - fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763781723
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763819281
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r562509041
##########
File path: debian/control
##########
@@ -37,6 +37,11 @@ Description: CloudStack usage monitor
The CloudStack usage monitor provides usage accounting across the entire cloud for
cloud operators to charge based on usage parameters.
+Package: cloudstack-ui
+Architecture: all
+Depends: ${misc:Depends}
Review comment:
Do we want users to be able to install just the cloudstack-ui package? If so, maybe we need to specify the actual dependencies needed for just running the UI.
Would that be cloudstack-common or is that not even needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765332082
<b>Trillian test result (tid-3407)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41979 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4605-t3407-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3615.16 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 3609.75 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 39.69 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766590395
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764949574
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766789528
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766590395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-765794271
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-763821874
Packages screenshot for file confirmation:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764613238
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768187797
> @weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/
@rhtyd thanks, I will test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-764953628
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
Posted by GitBox <gi...@apache.org>.
wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561166522
##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
+ # cloudstack-ui
+ mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+ cd ui && npm install && npm run build && cd ..
Review comment:
This assumes that npn is available on the system. However, that's not a guarantee.
The .deb (and .rpm) should have a build depends on 'npm'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org