You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2014/12/12 01:07:44 UTC
Review Request 28974: [HELIX-559] Fix Helix web admin performance
issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28974/
-----------------------------------------------------------
Review request for helix, Kishore Gopalakrishna and Shi Lu.
Bugs: 559
Repository: helix-git
Description
-------
[HELIX-559] Fix Helix web admin performance issues
Helix web admin has a couple of performance issues:
1) Use restlet default server which is slow
Need to switch to use jetty
2) Unnecessary json deserialization/serialization
For reading idealStates from helix web admin, we read as ZNRecord, serialize ZNRecord to byte arrays, and return the result. It's not necessary to do the der/ser which costs lots of CPU cycles. Instead, we can read the raw data as byte arrays and return it directly.
Diffs
-----
helix-admin-webapp/pom.xml 4e312d1
helix-admin-webapp/src/main/java/org/apache/helix/webapp/HelixAdminWebApp.java 991886c
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterRepresentationUtil.java 5e458c4
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ExternalViewResource.java 6ec28dc
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/IdealStateResource.java 0081922
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/InstanceResource.java e62fe5e
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupResource.java 6dc721d
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java ad4e934
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java f066dfc
helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJobQueuesResource.java 6c0e0e1
helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJsonParameters.java 383ac21
helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java c61dccd
pom.xml 92c1d7d
Diff: https://reviews.apache.org/r/28974/diff/
Testing
-------
mvn test
Thanks,
Zhen Zhang
Re: Review Request 28974: [HELIX-559] Fix Helix web admin performance
issues
Posted by Shi Lu <lu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28974/#review64822
-----------------------------------------------------------
Ship it!
Ship It!
- Shi Lu
On Dec. 12, 2014, 12:07 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28974/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 12:07 a.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Bugs: 559
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-559] Fix Helix web admin performance issues
>
> Helix web admin has a couple of performance issues:
>
> 1) Use restlet default server which is slow
> Need to switch to use jetty
>
> 2) Unnecessary json deserialization/serialization
> For reading idealStates from helix web admin, we read as ZNRecord, serialize ZNRecord to byte arrays, and return the result. It's not necessary to do the der/ser which costs lots of CPU cycles. Instead, we can read the raw data as byte arrays and return it directly.
>
>
> Diffs
> -----
>
> helix-admin-webapp/pom.xml 4e312d1
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/HelixAdminWebApp.java 991886c
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterRepresentationUtil.java 5e458c4
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ExternalViewResource.java 6ec28dc
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/IdealStateResource.java 0081922
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/InstanceResource.java e62fe5e
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupResource.java 6dc721d
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java ad4e934
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java f066dfc
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJobQueuesResource.java 6c0e0e1
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJsonParameters.java 383ac21
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java c61dccd
> pom.xml 92c1d7d
>
> Diff: https://reviews.apache.org/r/28974/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 28974: [HELIX-559] Fix Helix web admin performance
issues
Posted by Zhen Zhang <ne...@gmail.com>.
> On Dec. 12, 2014, 6:46 a.m., Kanak Biscuitwala wrote:
> > pom.xml, line 258
> > <https://reviews.apache.org/r/28974/diff/1/?file=789879#file789879line258>
> >
> > If I recall correctly, restlet 2.2.1 contains the ctrl+c CPU spike bug
the issue is caused by using restlet default server. switch to use embeded jetty will solve the spike issue.
- Zhen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28974/#review64879
-----------------------------------------------------------
On Dec. 12, 2014, 12:07 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28974/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 12:07 a.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Bugs: 559
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-559] Fix Helix web admin performance issues
>
> Helix web admin has a couple of performance issues:
>
> 1) Use restlet default server which is slow
> Need to switch to use jetty
>
> 2) Unnecessary json deserialization/serialization
> For reading idealStates from helix web admin, we read as ZNRecord, serialize ZNRecord to byte arrays, and return the result. It's not necessary to do the der/ser which costs lots of CPU cycles. Instead, we can read the raw data as byte arrays and return it directly.
>
>
> Diffs
> -----
>
> helix-admin-webapp/pom.xml 4e312d1
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/HelixAdminWebApp.java 991886c
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterRepresentationUtil.java 5e458c4
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ExternalViewResource.java 6ec28dc
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/IdealStateResource.java 0081922
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/InstanceResource.java e62fe5e
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupResource.java 6dc721d
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java ad4e934
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java f066dfc
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJobQueuesResource.java 6c0e0e1
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJsonParameters.java 383ac21
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java c61dccd
> pom.xml 92c1d7d
>
> Diff: https://reviews.apache.org/r/28974/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 28974: [HELIX-559] Fix Helix web admin performance
issues
Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28974/#review64879
-----------------------------------------------------------
pom.xml
<https://reviews.apache.org/r/28974/#comment107679>
If I recall correctly, restlet 2.2.1 contains the ctrl+c CPU spike bug
- Kanak Biscuitwala
On Dec. 11, 2014, 4:07 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28974/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 4:07 p.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Bugs: 559
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-559] Fix Helix web admin performance issues
>
> Helix web admin has a couple of performance issues:
>
> 1) Use restlet default server which is slow
> Need to switch to use jetty
>
> 2) Unnecessary json deserialization/serialization
> For reading idealStates from helix web admin, we read as ZNRecord, serialize ZNRecord to byte arrays, and return the result. It's not necessary to do the der/ser which costs lots of CPU cycles. Instead, we can read the raw data as byte arrays and return it directly.
>
>
> Diffs
> -----
>
> helix-admin-webapp/pom.xml 4e312d1
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/HelixAdminWebApp.java 991886c
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterRepresentationUtil.java 5e458c4
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ExternalViewResource.java 6ec28dc
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/IdealStateResource.java 0081922
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/InstanceResource.java e62fe5e
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupResource.java 6dc721d
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java ad4e934
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java f066dfc
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJobQueuesResource.java 6c0e0e1
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/resources/TestJsonParameters.java 383ac21
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java c61dccd
> pom.xml 92c1d7d
>
> Diff: https://reviews.apache.org/r/28974/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>