You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/23 18:18:52 UTC
[GitHub] [airflow] michaelmicheal opened a new pull request, #28561: navbar, cap dropdown size, and add scroll bar
michaelmicheal opened a new pull request, #28561:
URL: https://github.com/apache/airflow/pull/28561
This PR caps the size of a dropdown menu category, and adds a scrollbar past that level.
<img width="382" alt="Screen Shot 2022-12-23 at 1 17 31 PM" src="https://user-images.githubusercontent.com/40223998/209390328-786ab8f0-9e21-44b6-b6e6-7bf6a4375219.png">
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #28483
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #28561: navbar, cap dropdown size, and add scroll bar
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #28561:
URL: https://github.com/apache/airflow/pull/28561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #28561: navbar, cap dropdown size, and add scroll bar
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #28561:
URL: https://github.com/apache/airflow/pull/28561#discussion_r1059082676
##########
airflow/www/static/css/main.css:
##########
@@ -61,11 +61,19 @@ div.container {
color: #e2d2e2;
}
+/* If a category has a lot of menu items, we cap it, and
+ add a scroll bar */
+.navbar li.dropdown .dropdown-menu {
+ max-height: 300px;
+ overflow-y: auto;
+}
+
.navbar-nav li.dropdown:hover > .dropdown-menu,
.navbar-nav li.dropdown:focus-within > .dropdown-menu {
display: block;
}
+
Review Comment:
Linting doesn't like this extra new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org