You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/08 01:41:08 UTC
[GitHub] [superset] diegomedina248 opened a new pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
diegomedina248 opened a new pull request #19054:
URL: https://github.com/apache/superset/pull/19054
### SUMMARY
When the row count of a query executed in the SQL Lab is greater than the `DISPLAY_MAX_ROW` config, the row count shows incorrectly in the Query History tab.
The expected result is the row count to show the actual number of rows queried, regardless of the `DISPLAY_MAX_ROW` config, since that's only used to limit the result display.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1293" alt="Screen Shot 2022-03-07 at 22 37 46" src="https://user-images.githubusercontent.com/17252075/157148543-c9095973-d9e2-44d4-857a-1a3b2e300704.png">
After:
<img width="1293" alt="Screen Shot 2022-03-07 at 22 36 56" src="https://user-images.githubusercontent.com/17252075/157148468-a9a75c5a-dd18-492c-94f8-0b01e01b0e7c.png">
### TESTING INSTRUCTIONS
* Set the limit dropdown to 100k
* Run a query (`SELECT country_name from wb_health_population` for example) with more than 10k rows
* Run another query (a expensive one, like `SELECT * from wb_health_population`)
* Refresh the page while the previous query is executing
* Switch to the query history tab in SQL Lab
It might be needed to try this a couple of times to reproduce the issue
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #19054:
URL: https://github.com/apache/superset/pull/19054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1063272609
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1062265635
# [Codecov](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19054](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (329a7a6) into [master](https://codecov.io/gh/apache/superset/commit/e89f0abf95a5b49291bfa11f1d0277ade43eb2c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e89f0ab) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19054 +/- ##
==========================================
- Coverage 66.52% 66.52% -0.01%
==========================================
Files 1641 1641
Lines 63476 63477 +1
Branches 6444 6445 +1
==========================================
Hits 42227 42227
Misses 19585 19585
- Partials 1664 1665 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.28% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/SqlLab/components/ResultSet/index.tsx](https://codecov.io/gh/apache/superset/pull/19054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC9pbmRleC50c3g=) | `50.49% <0.00%> (-0.25%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/19054/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `33.15% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e89f0ab...329a7a6](https://codecov.io/gh/apache/superset/pull/19054?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1062414987
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1062416483
@rusackas Ephemeral environment spinning up at http://35.88.190.5:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1061421445
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19054: fix: show the total row count in the SQL Lab Query History tab when limited by DISPLAY_MAX_ROW
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19054:
URL: https://github.com/apache/superset/pull/19054#issuecomment-1061421679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org