You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/03 23:47:05 UTC

[GitHub] [druid] gianm commented on a change in pull request #9124: Add avro dependency to parquet extension

gianm commented on a change in pull request #9124: Add avro dependency to parquet extension
URL: https://github.com/apache/druid/pull/9124#discussion_r362996206
 
 

 ##########
 File path: extensions-core/parquet-extensions/pom.xml
 ##########
 @@ -411,11 +403,6 @@
       <artifactId>api-util</artifactId>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.avro</groupId>
-      <artifactId>avro</artifactId>
-      <scope>provided</scope>
 
 Review comment:
   How about keeping this in, but without `<scope>provided</scope>`.
   
   It seems like the dependency really is needed, but it is not provided, so it should have normal scope.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org