[jira] Commented: (HIVE-313) add UDF date_add, date_sub, datediff

["Raghotham Murthy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681172#action_12681172 ] 

Raghotham Murthy commented on HIVE-313:
---------------------------------------

Couple things.

1. What's the locale you would be using for parsing the date? I'm guessing PST? How would you handle the case where data for a day when there was no daylight savings is queried on a day when there is daylight savings?

2. In the test query, can you change one of the functions to take as input a column from a table rather than all tests being constants? This is just to be sure that there is no weirdness when processing constants vs columns.

3. Do you need the calendar variable in UDFDateDiff?

> add UDF date_add, date_sub, datediff
> ------------------------------------
>
>                 Key: HIVE-313
>                 URL: https://issues.apache.org/jira/browse/HIVE-313
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Zheng Shao
>         Attachments: HIVE-313.1.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_date-add
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_date-sub
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_datediff

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.