You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by jx...@apache.org on 2013/07/07 05:31:26 UTC
svn commit: r1500365 -
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java
Author: jxiang
Date: Sun Jul 7 03:31:25 2013
New Revision: 1500365
URL: http://svn.apache.org/r1500365
Log:
HBASE-8885 Fix and reenable TestGet failing#testDynamicFilter
Modified:
hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java
Modified: hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java?rev=1500365&r1=1500364&r2=1500365&view=diff
==============================================================================
--- hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java (original)
+++ hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestGet.java Sun Jul 7 03:31:25 2013
@@ -20,6 +20,7 @@
package org.apache.hadoop.hbase.client;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.fail;
import java.io.ByteArrayInputStream;
@@ -40,9 +41,7 @@ import org.apache.hadoop.hbase.util.Base
import org.apache.hadoop.hbase.util.Bytes;
import org.junit.Assert;
import org.junit.Test;
-import org.junit.Ignore;
import org.junit.experimental.categories.Category;
-import org.mortbay.log.Log;
import com.google.common.io.ByteStreams;
@@ -141,8 +140,15 @@ public class TestGet {
Assert.assertNull(get.getAttributesMap().get("attribute1"));
}
- @Ignore @Test
+ @Test
public void testDynamicFilter() throws Exception {
+ Configuration conf = HBaseConfiguration.create();
+ String localPath = conf.get("hbase.local.dir")
+ + File.separator + "jars" + File.separator;
+ File jarFile = new File(localPath, "MockFilter.jar");
+ jarFile.delete();
+ assertFalse("Should be deleted: " + jarFile.getPath(), jarFile.exists());
+
DataInput dis = ByteStreams.newDataInput(Base64.decode(WRITABLE_GET));
Get get = new Get();
try {
@@ -154,12 +160,6 @@ public class TestGet {
&& msg.contains("Can't find class test.MockFilter"));
}
- Configuration conf = HBaseConfiguration.create();
- String localPath = conf.get("hbase.local.dir")
- + File.separator + "jars" + File.separator;
- File jarFile = new File(localPath, "MockFilter.jar");
- jarFile.deleteOnExit();
-
FileOutputStream fos = new FileOutputStream(jarFile);
fos.write(Base64.decode(MOCK_FILTER_JAR));
fos.close();