You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chiwanpark <gi...@git.apache.org> on 2015/05/27 15:29:57 UTC
[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/734
[FLINK-2061] CSVReader: quotedStringParsing and includeFields yields ParseException
Fix the bug in `GenericCsvInputFormat` when skipped field is quoted string. I also added a unit test for this case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chiwanpark/flink FLINK-2061
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 99fb79beda88c73d80e630aa5e22e9ee401538ed
Author: Chiwan Park <ch...@icloud.com>
Date: 2015-05-27T13:24:59Z
[FLINK-2061] [java api] Fix GenericCsvInputFormat skipping fields error with quoted string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/734#issuecomment-106910782
Nice fix and good test case, thanks!
Will run the tests and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/734#issuecomment-106313923
Okay. :)
Because there is Stephen's email address in test code, I modified test code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2061] CSVReader: quotedStringParsing an...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/734#issuecomment-106286147
Hi @chiwanpark , thanks for the PR!
I'm a bit busy right now but will have a look at the PR soon.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---