You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 15:31:53 UTC

[GitHub] [airflow] ashb opened a new pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

ashb opened a new pull request #20170:
URL: https://github.com/apache/airflow/pull/20170


   * Allow point releases of AutoAPI (I used with 1.8.4 in all my testing)
   * Require at least Sphinx v4
   
     A few things got deprecated in Sphinx 4, and as this dep is only for
     us building docs we can pick and choose what we like without impacting
     users, so lets stay up-to-date.
   
   As noticed by @mik-laj in https://github.com/apache/airflow/pull/20079#discussion_r765878693
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb closed pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
ashb closed pull request #20170:
URL: https://github.com/apache/airflow/pull/20170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #20170:
URL: https://github.com/apache/airflow/pull/20170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20170:
URL: https://github.com/apache/airflow/pull/20170#issuecomment-990299634


   Actually - the previously merged change #20079 would already trigger the conflict. So I upgraded the constraints manually and this one can be merged any time now https://github.com/apache/airflow/commit/d44aee87d33bb4f14e7ae91e7c27a189526f76d0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20170:
URL: https://github.com/apache/airflow/pull/20170#issuecomment-989962573


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20170:
URL: https://github.com/apache/airflow/pull/20170#issuecomment-989966886


   They were on a good track to start refreshing quickly (after our tests stabilized) but stopped after the AWS docs publishing change -  (@mik-laj  promissed to fix it tonight):   https://github.com/apache/airflow/runs/4472124262?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20170:
URL: https://github.com/apache/airflow/pull/20170#issuecomment-989965095


   However. I'd wait with merging it until `constraints-main` will refresh automatically with the new sphinx 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #20170: Update minimum sphinx versions after upgrading sphinx-autoapi

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20170:
URL: https://github.com/apache/airflow/pull/20170#issuecomment-989976890


   Oh IAM perms failing on main build for docs upload.
   
   > Error: User: arn:aws:sts::***:assumed-role/ManualRunnerRole/i-0ecd356da541ffbc5 is not authorized to perform: sts:TagSession on resource: arn:aws:iam::***:role/GithubActionApacheAirflow
   
   Attempting to fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org