You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Jungtaek Lim <ka...@gmail.com> on 2016/07/08 11:43:14 UTC
Request for reviewing
Hi devs,
I've a pull request for a critical issue, and the patch modifies the heart
of supervisor code, so I'd like to make my patch get reviewed by more
people in community.
STORM-1934: Race condition between sync-supervisor and sync-processes
raises several strange issues
<https://issues.apache.org/jira/browse/STORM-1934>
Discussion is on this PR: https://github.com/apache/storm/pull/1528
Btw, since Storm 1.0.2 has lots of bugfix marked as 'Critical' and 'Major'
which are reported by users several times, I'd like to see 1.0.2
official release
sooner.
https://issues.apache.org/jira/issues/?jql=project%20%3D%20Storm%20AND%20%22epic%20link%22%20%3D%20STORM-1855%20order%20by%20priority
There're 4 unresolved issues but pull requests are available for 'Critical'
issues so once we resolve them I guess we could get other issues out of
1.0.2 and start working for releasing.
Given that STORM-1934 has two binding +1 votes, I'd like to wait for
several days, and merge if no further discussion is in progress.
Thanks in advance for taking your time.
Best regards,
Jungtaek Lim (HeartSaVioR)
Re: Request for reviewing
Posted by Jungtaek Lim <ka...@gmail.com>.
I thought STORM-1910 <https://issues.apache.org/jira/browse/STORM-1910> is
likely an improvement, not bugfix. That is why I included this to Storm
1.1.0 epic.
I'd like to see others' opinions as well. If we think it's a bugfix we can
include it to 1.0.2.
What do all of you think about this?
2016년 7월 15일 (금) 오전 4:43, Roshan Naik <ro...@hortonworks.com>님이 작성:
> STORM-1910
> -roshan
>
>
> On 7/14/16, 8:59 AM, "Jungtaek Lim" <ka...@gmail.com> wrote:
>
> >We seems close to make all issues for 1.0.2 epic resolved soon.
> >
> >Epic link: https://issues.apache.org/jira/browse/STORM-1855
> >All of open issues are in progress of reviewing. Most of them got +1 and
> >is
> >expected to be merged in soon.
> >
> >Is anyone having other critical or blocker issues which need to be
> >included
> >to 1.0.2?
> >
> >2016년 7월 9일 (토) 오전 12:34, P. Taylor Goetz <pt...@gmail.com>님이 작성:
> >
> >> Thanks Juntaek, I finally got some time to review it.
> >>
> >> Regarding the 1.0.2 release, there are a few open/in-progress issues
> >> remaining, but I think we should be in a position to cut a new RC
> >>sometime
> >> next week.
> >>
> >> -Taylor
> >>
> >>
> >> > On Jul 8, 2016, at 7:43 AM, Jungtaek Lim <ka...@gmail.com> wrote:
> >> >
> >> > Hi devs,
> >> >
> >> > I've a pull request for a critical issue, and the patch modifies the
> >> heart
> >> > of supervisor code, so I'd like to make my patch get reviewed by more
> >> > people in community.
> >> >
> >> > STORM-1934: Race condition between sync-supervisor and sync-processes
> >> > raises several strange issues
> >> > <https://issues.apache.org/jira/browse/STORM-1934>
> >> > Discussion is on this PR: https://github.com/apache/storm/pull/1528
> >> >
> >> > Btw, since Storm 1.0.2 has lots of bugfix marked as 'Critical' and
> >> 'Major'
> >> > which are reported by users several times, I'd like to see 1.0.2
> >> > official release
> >> > sooner.
> >> >
> >> >
> >>
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Storm%20AND%20
> >>%22epic%20link%22%20%3D%20STORM-1855%20order%20by%20priority
> >> >
> >> > There're 4 unresolved issues but pull requests are available for
> >> 'Critical'
> >> > issues so once we resolve them I guess we could get other issues out
> >>of
> >> > 1.0.2 and start working for releasing.
> >> >
> >> > Given that STORM-1934 has two binding +1 votes, I'd like to wait for
> >> > several days, and merge if no further discussion is in progress.
> >> >
> >> > Thanks in advance for taking your time.
> >> >
> >> > Best regards,
> >> > Jungtaek Lim (HeartSaVioR)
> >>
> >>
>
>
Re: Request for reviewing
Posted by Roshan Naik <ro...@hortonworks.com>.
STORM-1910
-roshan
On 7/14/16, 8:59 AM, "Jungtaek Lim" <ka...@gmail.com> wrote:
>We seems close to make all issues for 1.0.2 epic resolved soon.
>
>Epic link: https://issues.apache.org/jira/browse/STORM-1855
>All of open issues are in progress of reviewing. Most of them got +1 and
>is
>expected to be merged in soon.
>
>Is anyone having other critical or blocker issues which need to be
>included
>to 1.0.2?
>
>2016년 7월 9일 (토) 오전 12:34, P. Taylor Goetz <pt...@gmail.com>님이 작성:
>
>> Thanks Juntaek, I finally got some time to review it.
>>
>> Regarding the 1.0.2 release, there are a few open/in-progress issues
>> remaining, but I think we should be in a position to cut a new RC
>>sometime
>> next week.
>>
>> -Taylor
>>
>>
>> > On Jul 8, 2016, at 7:43 AM, Jungtaek Lim <ka...@gmail.com> wrote:
>> >
>> > Hi devs,
>> >
>> > I've a pull request for a critical issue, and the patch modifies the
>> heart
>> > of supervisor code, so I'd like to make my patch get reviewed by more
>> > people in community.
>> >
>> > STORM-1934: Race condition between sync-supervisor and sync-processes
>> > raises several strange issues
>> > <https://issues.apache.org/jira/browse/STORM-1934>
>> > Discussion is on this PR: https://github.com/apache/storm/pull/1528
>> >
>> > Btw, since Storm 1.0.2 has lots of bugfix marked as 'Critical' and
>> 'Major'
>> > which are reported by users several times, I'd like to see 1.0.2
>> > official release
>> > sooner.
>> >
>> >
>>
>>https://issues.apache.org/jira/issues/?jql=project%20%3D%20Storm%20AND%20
>>%22epic%20link%22%20%3D%20STORM-1855%20order%20by%20priority
>> >
>> > There're 4 unresolved issues but pull requests are available for
>> 'Critical'
>> > issues so once we resolve them I guess we could get other issues out
>>of
>> > 1.0.2 and start working for releasing.
>> >
>> > Given that STORM-1934 has two binding +1 votes, I'd like to wait for
>> > several days, and merge if no further discussion is in progress.
>> >
>> > Thanks in advance for taking your time.
>> >
>> > Best regards,
>> > Jungtaek Lim (HeartSaVioR)
>>
>>
Re: Request for reviewing
Posted by Jungtaek Lim <ka...@gmail.com>.
We seems close to make all issues for 1.0.2 epic resolved soon.
Epic link: https://issues.apache.org/jira/browse/STORM-1855
All of open issues are in progress of reviewing. Most of them got +1 and is
expected to be merged in soon.
Is anyone having other critical or blocker issues which need to be included
to 1.0.2?
2016년 7월 9일 (토) 오전 12:34, P. Taylor Goetz <pt...@gmail.com>님이 작성:
> Thanks Juntaek, I finally got some time to review it.
>
> Regarding the 1.0.2 release, there are a few open/in-progress issues
> remaining, but I think we should be in a position to cut a new RC sometime
> next week.
>
> -Taylor
>
>
> > On Jul 8, 2016, at 7:43 AM, Jungtaek Lim <ka...@gmail.com> wrote:
> >
> > Hi devs,
> >
> > I've a pull request for a critical issue, and the patch modifies the
> heart
> > of supervisor code, so I'd like to make my patch get reviewed by more
> > people in community.
> >
> > STORM-1934: Race condition between sync-supervisor and sync-processes
> > raises several strange issues
> > <https://issues.apache.org/jira/browse/STORM-1934>
> > Discussion is on this PR: https://github.com/apache/storm/pull/1528
> >
> > Btw, since Storm 1.0.2 has lots of bugfix marked as 'Critical' and
> 'Major'
> > which are reported by users several times, I'd like to see 1.0.2
> > official release
> > sooner.
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Storm%20AND%20%22epic%20link%22%20%3D%20STORM-1855%20order%20by%20priority
> >
> > There're 4 unresolved issues but pull requests are available for
> 'Critical'
> > issues so once we resolve them I guess we could get other issues out of
> > 1.0.2 and start working for releasing.
> >
> > Given that STORM-1934 has two binding +1 votes, I'd like to wait for
> > several days, and merge if no further discussion is in progress.
> >
> > Thanks in advance for taking your time.
> >
> > Best regards,
> > Jungtaek Lim (HeartSaVioR)
>
>
Re: Request for reviewing
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
Thanks Juntaek, I finally got some time to review it.
Regarding the 1.0.2 release, there are a few open/in-progress issues remaining, but I think we should be in a position to cut a new RC sometime next week.
-Taylor
> On Jul 8, 2016, at 7:43 AM, Jungtaek Lim <ka...@gmail.com> wrote:
>
> Hi devs,
>
> I've a pull request for a critical issue, and the patch modifies the heart
> of supervisor code, so I'd like to make my patch get reviewed by more
> people in community.
>
> STORM-1934: Race condition between sync-supervisor and sync-processes
> raises several strange issues
> <https://issues.apache.org/jira/browse/STORM-1934>
> Discussion is on this PR: https://github.com/apache/storm/pull/1528
>
> Btw, since Storm 1.0.2 has lots of bugfix marked as 'Critical' and 'Major'
> which are reported by users several times, I'd like to see 1.0.2
> official release
> sooner.
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Storm%20AND%20%22epic%20link%22%20%3D%20STORM-1855%20order%20by%20priority
>
> There're 4 unresolved issues but pull requests are available for 'Critical'
> issues so once we resolve them I guess we could get other issues out of
> 1.0.2 and start working for releasing.
>
> Given that STORM-1934 has two binding +1 votes, I'd like to wait for
> several days, and merge if no further discussion is in progress.
>
> Thanks in advance for taking your time.
>
> Best regards,
> Jungtaek Lim (HeartSaVioR)