You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/01/23 09:42:45 UTC
zeppelin git commit: [ZEPPELIN-1979] fix 'File size limit Exceeded'
when importing notes
Repository: zeppelin
Updated Branches:
refs/heads/master 14d13de06 -> de659a5ed
[ZEPPELIN-1979] fix 'File size limit Exceeded' when importing notes
### What is this PR for?
This is to fix the problem with import of note because of size limitations. Actually it seemed to be working in anonymous mode, and I noticed the problem only when authentication is enabled.
### What type of PR is it?
Bug Fix
### Todos
* [x] - list conf on successful login
### What is the Jira issue?
[ZEPPELIN-1979](https://issues.apache.org/jira/browse/ZEPPELIN-1979)
### How should this be tested?
1. set note msg size value in `conf/zeppelin-env.sh` e.g.
```
export ZEPPELIN_WEBSOCKET_MAX_TEXT_MESSAGE_SIZE="4096000"
```
2. login to Zeppelin
3. try to import note unde 4MB
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Khalid Huseynov <kh...@gmail.com>
Closes #1913 from khalidhuseynov/fix/note-message-size and squashes the following commits:
3cf02fe [Khalid Huseynov] list conf on login
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/de659a5e
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/de659a5e
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/de659a5e
Branch: refs/heads/master
Commit: de659a5ed882ffca37626b5f6d5e5f0f014a2e01
Parents: 14d13de
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Wed Jan 18 21:28:56 2017 -0800
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon Jan 23 01:42:41 2017 -0800
----------------------------------------------------------------------
zeppelin-web/src/components/navbar/navbar.controller.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/de659a5e/zeppelin-web/src/components/navbar/navbar.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.controller.js b/zeppelin-web/src/components/navbar/navbar.controller.js
index 23baf5a..b226d4d 100644
--- a/zeppelin-web/src/components/navbar/navbar.controller.js
+++ b/zeppelin-web/src/components/navbar/navbar.controller.js
@@ -85,6 +85,10 @@ function NavCtrl($scope, $rootScope, $http, $routeParams, $location,
return ($routeParams.noteId === noteId);
}
+ function listConfigurations() {
+ websocketMsgSrv.listConfigurations();
+ }
+
function loadNotes() {
websocketMsgSrv.getNoteList();
}
@@ -135,6 +139,7 @@ function NavCtrl($scope, $rootScope, $http, $routeParams, $location,
});
$scope.$on('loginSuccess', function(event, param) {
+ listConfigurations();
loadNotes();
});
@@ -153,4 +158,3 @@ function NavCtrl($scope, $rootScope, $http, $routeParams, $location,
});
}
}
-