You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2014/08/21 00:14:54 UTC

[GitHub] spark pull request: [SPARK-3140] Clarify confusing PySpark excepti...

GitHub user andrewor14 opened a pull request:

    https://github.com/apache/spark/pull/2067

    [SPARK-3140] Clarify confusing PySpark exception message

    We read the py4j port from the stdout of the `bin/spark-submit` subprocess. If there is interference in stdout (e.g. a random echo in `spark-submit`), we throw an exception with a warning message. We do not, however, distinguish between this case from the case where no stdout is produced at all.
    
    I wasted a non-trivial amount of time being baffled by this exception in search of places where I print random whitespace (in vain, of course). A clearer exception message that distinguishes between these cases will prevent future headaches that I have gone through.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewor14/spark python-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2067
    
----
commit e96a7a0016502820f325c39d71b236b2b39e0cb6
Author: Andrew Or <an...@gmail.com>
Date:   2014-08-20T22:09:33Z

    Distinguish between unexpected output and no output at all

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-3140] Clarify confusing PySpark excepti...

Posted by andrewor14 <gi...@git.apache.org>.

Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/2067#issuecomment-52852691
  
    @kayousterhout @JoshRosen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-3140] Clarify confusing PySpark excepti...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2067#issuecomment-52861567
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19008/consoleFull) for   PR 2067 at commit [`742f823`](https://github.com/apache/spark/commit/742f82311b1733f735fb5c2369aea7d1ca1d8774).
     * This patch **passes** unit tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `  shift # Ignore main class (org.apache.spark.deploy.SparkSubmit) and use our own`
      * `case class SparkListenerTaskStart(stageId: Int, stageAttemptId: Int, taskInfo: TaskInfo)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-3140] Clarify confusing PySpark excepti...

Posted by andrewor14 <gi...@git.apache.org>.

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2067#discussion_r16511511
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -54,12 +54,18 @@ def preexec_func():
                 gateway_port = proc.stdout.readline()
                 gateway_port = int(gateway_port)
             except ValueError:
    +            # Grab the remaining lines of stdout
                 (stdout, _) = proc.communicate()
                 exit_code = proc.poll()
                 error_msg = "Launching GatewayServer failed"
                 error_msg += " with exit code %d! " % exit_code if exit_code else "! "
    --- End diff --
    
    Yeah, I misread it too the first time after reading your comment :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-3140] Clarify confusing PySpark excepti...

Posted by andrewor14 <gi...@git.apache.org>.

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2067#discussion_r16511219
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -54,12 +54,18 @@ def preexec_func():
                 gateway_port = proc.stdout.readline()
                 gateway_port = int(gateway_port)
             except ValueError:
    +            # Grab the remaining lines of stdout
                 (stdout, _) = proc.communicate()
                 exit_code = proc.poll()
                 error_msg = "Launching GatewayServer failed"
                 error_msg += " with exit code %d! " % exit_code if exit_code else "! "
    --- End diff --
    
    wait, when there's no exit code it looks like this, no?
    ```
    Launching GatewayServer failed! (Warning: ...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org