[jira] [Created] (CALCITE-5677) Fix unparsing for BigQuery SUBSTR

["Tanner Clary (Jira)" <ji...@apache.org>]

Tanner Clary created CALCITE-5677:
-------------------------------------

             Summary: Fix unparsing for BigQuery SUBSTR
                 Key: CALCITE-5677
                 URL: https://issues.apache.org/jira/browse/CALCITE-5677
             Project: Calcite
          Issue Type: Bug
            Reporter: Tanner Clary
            Assignee: Tanner Clary


BigQuery's {{SUBSTR(value, position[, length])}} function currently gets translated to the standard {{SUBSTRING(value FROM position[ FOR length])]}. BigQuery expects the arguments to be comma-separated rather than the use of the {{FROM}} and {{FOR}} keywords. 

Hive addresses this issue by adding onto {{HiveSqlDialect#unparseCall}} method. I believe BigQuery should do something similar to avoid this incorrect translation. The docs for the {{SUBSTR}} (and alias {{SUBSTRING}}) function may be found [here|https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#substr].

I will open a PR shortly that implements my suggestion and adds a couple of tests as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)