[superset] branch master updated: Update chromatic PR action to have access to Job outputs (#21224)

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e2ab966910 Update chromatic PR action to have access to Job outputs (#21224)
e2ab966910 is described below

commit e2ab96691045e08c9406ba1df65f2c52fb4188a8
Author: Eric Briscoe <er...@gmail.com>
AuthorDate: Fri Aug 26 16:21:22 2022 -0700

    Update chromatic PR action to have access to Job outputs (#21224)
    
    Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs
---
 .github/workflows/chromatic-pr.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/chromatic-pr.yml b/.github/workflows/chromatic-pr.yml
index 52982a8ad9..1ef2646e5a 100644
--- a/.github/workflows/chromatic-pr.yml
+++ b/.github/workflows/chromatic-pr.yml
@@ -42,8 +42,13 @@ jobs:
   chromatic-deployment:
     # Operating System
     runs-on: ubuntu-latest
+    # define outputs that can be used in the storybook-link-comment job
+    outputs:
+      storybookUrl: ${{ steps.chromatic-deploy.outputs.storybookUrl }}
+      buildUrl: ${{ steps.chromatic-deploy.outputs.buildUrl }}
     # Job steps
     steps:
+      - id: chromatic-deploy
       - uses: actions/checkout@v1
       - name: Install dependencies
         run: npm ci
@@ -76,5 +81,5 @@ jobs:
               issue_number: context.issue.number,
               owner: context.repo.owner,
               repo: context.repo.repo,
-              body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }}.  Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }} '
+              body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }}  Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }}'
             })