[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

["Mark Miller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799945#comment-17799945 ] 

Mark Miller commented on SOLR-10466:
------------------------------------

Depends on what you closing. Many things do not close very fast. And as a
random example, closing 10 things sequentially that take one second each
closes in 10 seconds, and closing 10 things that take one second each doing
10 in parallel generally takes one second.


> setDefaultCollection should be deprecated in favor of SolrClientBuilder methods
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-10466
>                 URL: https://issues.apache.org/jira/browse/SOLR-10466
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Assignee: Eric Pugh
>            Priority: Minor
>             Fix For: 7.0, main (10.0), 9.3
>
>          Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setDefaultCollection}} setter on all {{SolrClient}} implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org