You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Martijn Visser <ma...@apache.org> on 2022/05/11 18:09:55 UTC

[DISCUSS] Release first version of Elasticsearch connector from external repository

Hi everyone,

As mentioned in the previous update [1] we were working on the final step
for moving out the Elasticsearch connector, which was related to the
documentation integration. This has now been completed: the documentation
you see on
https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/elasticsearch/
is generated via the documentation in the Elasticsearch external
repository.

In our plan we outlined that when we moved things out, we would create a
first release out of this repository [2]. I would like to take that step to
complete this first connector and move on to the next one.

If there's any feedback or questions, do let me know. Else I'll reach out
to some PMCs to help facilitate this release and we'll open a VOTE thread
shortly.

Best regards,

Martijn Visser
https://twitter.com/MartijnVisser82
https://github.com/MartijnVisser

[1] https://lists.apache.org/thread/8k1xonqt7hn0xldbky1cxfx3fzh6sj7h
[2] https://lists.apache.org/thread/vqbjoo94wwqcvo32c80dkmp7r5gmy68r

Re: [DISCUSS] Release first version of Elasticsearch connector from external repository

Posted by Jing Ge <ji...@ververica.com>.
Thanks Chesnay for the notes.

The 1.16-SNAPSHOT dependency is only a temporary solution. Once all related
commits w.r.t. architecture tests have been cp from the master to 1.15, the
dependency will be changed to 1.15. It is on the todo list.

On Tue, May 17, 2022 at 10:04 AM Chesnay Schepler <ch...@apache.org>
wrote:

> some notes:
>
> - the ES repo currently depends on 1.16-SNAPSHOT; so we'd have to go
> back to 1.15 to do such a release as Konstantin proposed. This may have
> repercussions on the architecture tests.
> - the version scheme in the repo does not yet match what was discussed
> in the original proposal (which I think should be 3.0-SNAPSHOT)
> - we aren't able to publish the javadocs for the ES connector on the
> website. Are we fine with that?
> - there is no tooling in the ES repo for actually doing the release.
> - there is currently no e2e test coverage for the moved connector. The
> e2e tests living on the Flink side run against the connector version in
> Flink. Will we just change the version after the release (implying that
> technically the connector is released without e2e coverage)?
>
> On 11/05/2022 21:35, Konstantin Knauf wrote:
> > Hi Martijn,
> >
> > +1 to do a release which is compatible with Flink 1.5.x. With the
> release,
> > we should add something like a compatibility matrix to the documentation,
> > but I am sure that's already on your list.
> >
> > Cheers,
> >
> > Konstantin
> >
> >
> >
> >
> > Am Mi., 11. Mai 2022 um 20:10 Uhr schrieb Martijn Visser <
> > martijnvisser@apache.org>:
> >
> >> Hi everyone,
> >>
> >> As mentioned in the previous update [1] we were working on the final
> step
> >> for moving out the Elasticsearch connector, which was related to the
> >> documentation integration. This has now been completed: the
> documentation
> >> you see on
> >>
> >>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/elasticsearch/
> >> is generated via the documentation in the Elasticsearch external
> >> repository.
> >>
> >> In our plan we outlined that when we moved things out, we would create a
> >> first release out of this repository [2]. I would like to take that
> step to
> >> complete this first connector and move on to the next one.
> >>
> >> If there's any feedback or questions, do let me know. Else I'll reach
> out
> >> to some PMCs to help facilitate this release and we'll open a VOTE
> thread
> >> shortly.
> >>
> >> Best regards,
> >>
> >> Martijn Visser
> >> https://twitter.com/MartijnVisser82
> >> https://github.com/MartijnVisser
> >>
> >> [1] https://lists.apache.org/thread/8k1xonqt7hn0xldbky1cxfx3fzh6sj7h
> >> [2] https://lists.apache.org/thread/vqbjoo94wwqcvo32c80dkmp7r5gmy68r
> >>
> >
>
>

Re: [DISCUSS] Release first version of Elasticsearch connector from external repository

Posted by Chesnay Schepler <ch...@apache.org>.
some notes:

- the ES repo currently depends on 1.16-SNAPSHOT; so we'd have to go 
back to 1.15 to do such a release as Konstantin proposed. This may have 
repercussions on the architecture tests.
- the version scheme in the repo does not yet match what was discussed 
in the original proposal (which I think should be 3.0-SNAPSHOT)
- we aren't able to publish the javadocs for the ES connector on the 
website. Are we fine with that?
- there is no tooling in the ES repo for actually doing the release.
- there is currently no e2e test coverage for the moved connector. The 
e2e tests living on the Flink side run against the connector version in 
Flink. Will we just change the version after the release (implying that 
technically the connector is released without e2e coverage)?

On 11/05/2022 21:35, Konstantin Knauf wrote:
> Hi Martijn,
>
> +1 to do a release which is compatible with Flink 1.5.x. With the release,
> we should add something like a compatibility matrix to the documentation,
> but I am sure that's already on your list.
>
> Cheers,
>
> Konstantin
>
>
>
>
> Am Mi., 11. Mai 2022 um 20:10 Uhr schrieb Martijn Visser <
> martijnvisser@apache.org>:
>
>> Hi everyone,
>>
>> As mentioned in the previous update [1] we were working on the final step
>> for moving out the Elasticsearch connector, which was related to the
>> documentation integration. This has now been completed: the documentation
>> you see on
>>
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/elasticsearch/
>> is generated via the documentation in the Elasticsearch external
>> repository.
>>
>> In our plan we outlined that when we moved things out, we would create a
>> first release out of this repository [2]. I would like to take that step to
>> complete this first connector and move on to the next one.
>>
>> If there's any feedback or questions, do let me know. Else I'll reach out
>> to some PMCs to help facilitate this release and we'll open a VOTE thread
>> shortly.
>>
>> Best regards,
>>
>> Martijn Visser
>> https://twitter.com/MartijnVisser82
>> https://github.com/MartijnVisser
>>
>> [1] https://lists.apache.org/thread/8k1xonqt7hn0xldbky1cxfx3fzh6sj7h
>> [2] https://lists.apache.org/thread/vqbjoo94wwqcvo32c80dkmp7r5gmy68r
>>
>


Re: [DISCUSS] Release first version of Elasticsearch connector from external repository

Posted by Konstantin Knauf <kn...@apache.org>.
Hi Martijn,

+1 to do a release which is compatible with Flink 1.5.x. With the release,
we should add something like a compatibility matrix to the documentation,
but I am sure that's already on your list.

Cheers,

Konstantin




Am Mi., 11. Mai 2022 um 20:10 Uhr schrieb Martijn Visser <
martijnvisser@apache.org>:

> Hi everyone,
>
> As mentioned in the previous update [1] we were working on the final step
> for moving out the Elasticsearch connector, which was related to the
> documentation integration. This has now been completed: the documentation
> you see on
>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/elasticsearch/
> is generated via the documentation in the Elasticsearch external
> repository.
>
> In our plan we outlined that when we moved things out, we would create a
> first release out of this repository [2]. I would like to take that step to
> complete this first connector and move on to the next one.
>
> If there's any feedback or questions, do let me know. Else I'll reach out
> to some PMCs to help facilitate this release and we'll open a VOTE thread
> shortly.
>
> Best regards,
>
> Martijn Visser
> https://twitter.com/MartijnVisser82
> https://github.com/MartijnVisser
>
> [1] https://lists.apache.org/thread/8k1xonqt7hn0xldbky1cxfx3fzh6sj7h
> [2] https://lists.apache.org/thread/vqbjoo94wwqcvo32c80dkmp7r5gmy68r
>


-- 
https://twitter.com/snntrable
https://github.com/knaufk