You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 10:27:36 UTC
[GitHub] [airflow] potiuk opened a new issue #11298: Kubernetes - related backports needs some fixes
potiuk opened a new issue #11298:
URL: https://github.com/apache/airflow/issues/11298
The "cncf.kubernetes" still has problems when releasing backport packages.
Reported by @mik-laj in https://lists.apache.org/thread.html/rd7b8fa87ac8117812e9883b342876eaee6039ce8e421cab3e454406c%40%3Cdev.airflow.apache.org%3E:
**Apache Airflow version**:
Master Backport packages for "cncf.kubernetes" and "google"
Installed on top of 1.10.12
**What happened**:
The example_spark_kubernetes_spark_pi.yaml from our repository and example DAG works
- airflow/providers/cncf/kubernetes/example_dags/example_kubernetes.py,
- airflow/providers/cncf/kubernetes/example_dags/example_spark_kubernetes_spark_pi.yaml
But it does not work with `example_kubernetes_operator`. I performed the following steps which ended with an error.
```
$ curl -LO https://raw.githubusercontent.com/apache/airflow/master/airflow/providers/cncf/kubernetes/example_dags/example_kubernetes.py
$ cat example_kubernetes.py | sed 's/operators.bash/operators.bash_operator/g' | sed 's/in_cluster=True/in_cluster=False/g' > a.py
$ mv a.py example_kubernetes.py
$ airflow test example_kubernetes_operator write-xcom 2010-01-01
.....
[2020-10-04 23:29:06,623] {taskinstance.py:1150} ERROR - type object 'PodGenerator' has no attribute 'add_xcom_sidecar'
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.6/site-packages/airflow/models/taskinstance.py", line 984, in _run_raw_task
result = task_copy.execute(context=context)
File "/home/airflow/.local/lib/python3.6/site-packages/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py", line 269, in execute
self.pod = self.create_pod_request_obj()
File "/home/airflow/.local/lib/python3.6/site-packages/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py", line 405, in create_pod_request_obj
pod = PodGenerator.add_xcom_sidecar(pod)
AttributeError: type object 'PodGenerator' has no attribute 'add_xcom_sidecar'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-706786150
Hi @michalslowikowski00 lemme know if you need any help on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
dimberman closed issue #11298:
URL: https://github.com/apache/airflow/issues/11298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-706911029
@dimberman sure. Today I have more to time to dive into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-704900531
I'll take care of it. You can subscribe me to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-704178524
cc: @dimberman @mik-laj @michalslowikowski00
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-704178827
This is a pre-requisite to relese cncf.kubernetes and related GKE Pod operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-707577339
@dimberman no worries.. ;)
If that code fixes the issue then everybody wins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-707281955
@michalmisiewicz Sounds good, I'm around so feel free to ping me on the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-707329722
Hi all,
I think I found the solution (apologies for jumping in @michalmisiewicz though I'd super appreciate a double check on this :) https://github.com/apache/airflow/pull/11478)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 edited a comment on issue #11298: Kubernetes - related backports needs some fixes for xcom cases
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 edited a comment on issue #11298:
URL: https://github.com/apache/airflow/issues/11298#issuecomment-704900531
I'll take care of it. You can assign me to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org