You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cxzl25 <gi...@git.apache.org> on 2018/05/18 16:00:10 UTC
[GitHub] spark pull request #21364: [SPARK-20173][SQL]Float-point numbers are display...
GitHub user cxzl25 opened a pull request:
https://github.com/apache/spark/pull/21364
[SPARK-20173][SQL]Float-point numbers are displayed with different precision in ThriftServer2
## What changes were proposed in this pull request?
When querying float-point numbers , the values displayed on beeline or jdbc are with different precision.
```
SELECT CAST(1.23 AS FLOAT)
Result:
1.2300000190734863
```
According to these two jira:
[HIVE-11802](https://issues.apache.org/jira/browse/HIVE-11802)
[HIVE-11832](https://issues.apache.org/jira/browse/HIVE-11832)
Make a slight modification to the spark hive thrift server.
## How was this patch tested?
HiveThriftBinaryServerSuite
test("JDBC query float-point number")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cxzl25/spark fix_float_number_display
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21364
----
commit 137abed62a75ea453a0d3c8436d9aa08b9abee36
Author: sychen <sy...@...>
Date: 2018-05-18T15:39:35Z
Float-point numbers are displayed with different precision in Beeline/JDBC
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21364
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21364
**[Test build #90811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90811/testReport)** for PR 21364 at commit [`137abed`](https://github.com/apache/spark/commit/137abed62a75ea453a0d3c8436d9aa08b9abee36).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by cxzl25 <gi...@git.apache.org>.
Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/21364
ping @gatorsmile @liufengdb
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21364: [SPARK-24317][SQL]Float-point numbers are display...
Posted by cxzl25 <gi...@git.apache.org>.
Github user cxzl25 closed the pull request at:
https://github.com/apache/spark/pull/21364
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21364
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21364: [SPARK-24317][SQL]Float-point numbers are display...
Posted by cxzl25 <gi...@git.apache.org>.
GitHub user cxzl25 reopened a pull request:
https://github.com/apache/spark/pull/21364
[SPARK-24317][SQL]Float-point numbers are displayed with different precision in ThriftServer2
## What changes were proposed in this pull request?
When querying float-point numbers , the values displayed on beeline or jdbc are with different precision.
```
SELECT CAST(1.23 AS FLOAT)
Result:
1.2300000190734863
```
According to these two jira:
[HIVE-11802](https://issues.apache.org/jira/browse/HIVE-11802)
[HIVE-11832](https://issues.apache.org/jira/browse/HIVE-11832)
Make a slight modification to the spark hive thrift server.
## How was this patch tested?
HiveThriftBinaryServerSuite
test("JDBC query float-point number")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cxzl25/spark fix_float_number_display
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21364
----
commit 137abed62a75ea453a0d3c8436d9aa08b9abee36
Author: sychen <sy...@...>
Date: 2018-05-18T15:39:35Z
Float-point numbers are displayed with different precision in Beeline/JDBC
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21364
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21364
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21364
cc @srinathshankar @yuchenhuo
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21364
the change itself LGTM, cc @cloud-fan @gatorsmile: can we trigger a build for this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21364
cc @liufengdb
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21364: [SPARK-24317][SQL]Float-point numbers are display...
Posted by cxzl25 <gi...@git.apache.org>.
Github user cxzl25 closed the pull request at:
https://github.com/apache/spark/pull/21364
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21364
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90811/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21364: [SPARK-24317][SQL]Float-point numbers are displayed with...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21364
**[Test build #90811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90811/testReport)** for PR 21364 at commit [`137abed`](https://github.com/apache/spark/commit/137abed62a75ea453a0d3c8436d9aa08b9abee36).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org