You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2015/12/14 13:01:02 UTC

Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/
-----------------------------------------------------------

Review request for Falcon and PRAGYA MITTAL.


Bugs: FALCON-1652
    https://issues.apache.org/jira/browse/FALCON-1652


Repository: falcon-git


Description
-------

Documentation for enabling native scheduler in falcon


Diffs
-----

  docs/src/site/twiki/Configuration.twiki 74da49a 
  docs/src/site/twiki/FalconDocumentation.twiki f384a42 
  docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
  docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
  src/conf/startup.properties 1694930 

Diff: https://reviews.apache.org/r/41342/diff/


Testing
-------

Compiled and ensured the html shows up properly on the browser.


Thanks,

Pallavi Rao


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110479
-----------------------------------------------------------

Ship it!


Ship It!

- pavan kumar kolamuri


On Dec. 15, 2015, 9:22 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 9:22 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   scheduler/pom.xml c934b3e 
>   src/conf/startup.properties 95d792b 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110475
-----------------------------------------------------------

Ship it!


Ship It!

- PRAGYA MITTAL


On Dec. 15, 2015, 9:22 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 9:22 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   scheduler/pom.xml c934b3e 
>   src/conf/startup.properties 95d792b 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110470
-----------------------------------------------------------

Ship it!


Ship It!

- Ajay Yadava


On Dec. 15, 2015, 9:22 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 9:22 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   scheduler/pom.xml c934b3e 
>   src/conf/startup.properties 95d792b 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 9:22 a.m.)


Review request for Falcon and PRAGYA MITTAL.


Changes
-------

Addressed review comments


Bugs: FALCON-1652
    https://issues.apache.org/jira/browse/FALCON-1652


Repository: falcon-git


Description
-------

Documentation for enabling native scheduler in falcon


Diffs (updated)
-----

  docs/src/site/twiki/Configuration.twiki 74da49a 
  docs/src/site/twiki/FalconDocumentation.twiki f384a42 
  docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
  docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
  scheduler/pom.xml c934b3e 
  src/conf/startup.properties 95d792b 

Diff: https://reviews.apache.org/r/41342/diff/


Testing
-------

Compiled and ensured the html shows up properly on the browser.


Thanks,

Pallavi Rao


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Pallavi Rao <pa...@inmobi.com>.

> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 76
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line76>
> >
> >     In distributed mode, how can multiple servers share same derby db ? Any configuration required for it.

Not applicable for Derby DB.. clarified that.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 81
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line81>
> >
> >     How to run this command in distributed mode (we can mention via server it has to be run)

Clarified that only Falcon server needs to maintain state and the script needs to be run for Falcon server installation alone.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 102
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line102>
> >
> >     Can we add any other db that we plan to support in future.

Mentioned that we may extend support to other DBs.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 110
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line110>
> >
> >     Is falcon dependent on a specific version of mysql ?

I can mention the version it has been tested against. It should work with any version above that too.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 112
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line112>
> >
> >     falcon.statestore.jdbc.driver in case of mysql ?

jdbc.url is the only property that needs to be changed. Have called it out.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 113
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line113>
> >
> >     *.falcon.statestore.jdbc.username=sa
> >     *.falcon.statestore.jdbc.password=
> >     *.falcon.statestore.connection.data.source=org.apache.commons.dbcp.BasicDataSource 
> >     
> >     Does these property remain same for both mysql and derby ?

Yes. Have called it out.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 114
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line114>
> >
> >     Can multiple servers use same mysql db?

Yes. Mentioned the same in the doc.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 116
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line116>
> >
> >     Does user need to create 'statestore' db prior to running the script. If so , can root user do it or it has to a specific user ?

For MySQL yes.. For derby, not necessary. Updated the doc.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 117
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line117>
> >
> >     Is mysql-connector.jar bundled in falcon or user needs to copy it. If user has to copy then where should we copy ?

Nope. Absence of documentation means the user does not need to do anything :-).


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 137
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line137>
> >
> >     Does migration require engine change in startup.properties ?

Apart from enabling native scheduler nothing else. Called it out explicitly.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 48
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164445#file1164445line48>
> >
> >     Does it mean we dont need OozieWorkflowEngine in the long run.
> >     If user wants to schedule some job via oozie and then some via scheduler, will this work even without changing engine in startup.properties .
> >     
> >     Can we be more clear on property dependency on engine (if any)

Have tried to word this a little more clearly.


> On Dec. 15, 2015, 6:53 a.m., PRAGYA MITTAL wrote:
> > docs/src/site/twiki/falconcli/Schedule.twiki, line 16
> > <https://reviews.apache.org/r/41342/diff/2/?file=1164446#file1164446line16>
> >
> >     *.workflow.engine.impl=org.apache.falcon.workflow.engine.OozieWorkflowEngine and user gives this property, what is the expected behaviour. Is this property dependent of the engine defined in startup.properties.

Details have been added to FalconNativeScheduler page.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110433
-----------------------------------------------------------


On Dec. 15, 2015, 5:27 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 5:27 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110433
-----------------------------------------------------------



docs/src/site/twiki/FalconNativeScheduler.twiki (line 48)
<https://reviews.apache.org/r/41342/#comment170307>

    Does it mean we dont need OozieWorkflowEngine in the long run.
    If user wants to schedule some job via oozie and then some via scheduler, will this work even without changing engine in startup.properties .
    
    Can we be more clear on property dependency on engine (if any)



docs/src/site/twiki/FalconNativeScheduler.twiki (line 76)
<https://reviews.apache.org/r/41342/#comment170311>

    In distributed mode, how can multiple servers share same derby db ? Any configuration required for it.



docs/src/site/twiki/FalconNativeScheduler.twiki (line 81)
<https://reviews.apache.org/r/41342/#comment170312>

    How to run this command in distributed mode (we can mention via server it has to be run)



docs/src/site/twiki/FalconNativeScheduler.twiki (line 102)
<https://reviews.apache.org/r/41342/#comment170313>

    Can we add any other db that we plan to support in future.



docs/src/site/twiki/FalconNativeScheduler.twiki (line 107)
<https://reviews.apache.org/r/41342/#comment170314>

    What will be the end point in case multiple servers share same db . Is it configurable ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 110)
<https://reviews.apache.org/r/41342/#comment170320>

    Is falcon dependent on a specific version of mysql ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 112)
<https://reviews.apache.org/r/41342/#comment170317>

    falcon.statestore.jdbc.driver in case of mysql ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 113)
<https://reviews.apache.org/r/41342/#comment170318>

    *.falcon.statestore.jdbc.username=sa
    *.falcon.statestore.jdbc.password=
    *.falcon.statestore.connection.data.source=org.apache.commons.dbcp.BasicDataSource 
    
    Does these property remain same for both mysql and derby ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 114)
<https://reviews.apache.org/r/41342/#comment170315>

    Can multiple servers use same mysql db?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 116)
<https://reviews.apache.org/r/41342/#comment170316>

    Does user need to create 'statestore' db prior to running the script. If so , can root user do it or it has to a specific user ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 117)
<https://reviews.apache.org/r/41342/#comment170321>

    Is mysql-connector.jar bundled in falcon or user needs to copy it. If user has to copy then where should we copy ?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 137)
<https://reviews.apache.org/r/41342/#comment170319>

    Does migration require engine change in startup.properties ?



docs/src/site/twiki/falconcli/Schedule.twiki (line 16)
<https://reviews.apache.org/r/41342/#comment170294>

    *.workflow.engine.impl=org.apache.falcon.workflow.engine.OozieWorkflowEngine and user gives this property, what is the expected behaviour. Is this property dependent of the engine defined in startup.properties.


- PRAGYA MITTAL


On Dec. 15, 2015, 5:27 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 5:27 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Pallavi Rao <pa...@inmobi.com>.

> On Dec. 15, 2015, 5:50 a.m., pavan kumar kolamuri wrote:
> > docs/src/site/twiki/Configuration.twiki, line 105
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162300#file1162300line105>
> >
> >     I think we should mention about DB also here.

IMO, it will become too verbose as this is just an architecture section. Have added all DB details in the Native Scheduler page.


> On Dec. 15, 2015, 5:50 a.m., pavan kumar kolamuri wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 77
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162302#file1162302line77>
> >
> >     This was changed in FalconStateStoreDBCLI with mysql patch

Yep. Picked it up in my later patch.


> On Dec. 15, 2015, 5:50 a.m., pavan kumar kolamuri wrote:
> > src/conf/startup.properties, line 31
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162304#file1162304line31>
> >
> >     Can we still schedule process in Native Scheduler even workflow.engine.impl was set to org.apache.falcon.workflow.engine.OozieWorkflowEngine ?

Yes. Native scheduler will always be available. Have updated the doc. to call out the difference explicitly.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110411
-----------------------------------------------------------


On Dec. 15, 2015, 5:27 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 5:27 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110411
-----------------------------------------------------------



docs/src/site/twiki/Configuration.twiki (line 105)
<https://reviews.apache.org/r/41342/#comment170261>

    I think we should mention about DB also here.



docs/src/site/twiki/FalconDocumentation.twiki (line 40)
<https://reviews.apache.org/r/41342/#comment170263>

    Nit : spelling mistake scheduling



docs/src/site/twiki/FalconDocumentation.twiki (line 41)
<https://reviews.apache.org/r/41342/#comment170265>

    Nit : spelling mistake Falcon in 4th line.



docs/src/site/twiki/FalconNativeScheduler.twiki (line 4)
<https://reviews.apache.org/r/41342/#comment170266>

    Minor nit : scheduling spelling mistake



docs/src/site/twiki/FalconNativeScheduler.twiki (line 77)
<https://reviews.apache.org/r/41342/#comment170260>

    This was changed in FalconStateStoreDBCLI with mysql patch



src/conf/startup.properties (line 31)
<https://reviews.apache.org/r/41342/#comment170273>

    Can we still schedule process in Native Scheduler even workflow.engine.impl was set to org.apache.falcon.workflow.engine.OozieWorkflowEngine ?


- pavan kumar kolamuri


On Dec. 15, 2015, 5:27 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 5:27 a.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 5:27 a.m.)


Review request for Falcon and PRAGYA MITTAL.


Changes
-------

Review comments addressed.


Bugs: FALCON-1652
    https://issues.apache.org/jira/browse/FALCON-1652


Repository: falcon-git


Description
-------

Documentation for enabling native scheduler in falcon


Diffs (updated)
-----

  docs/src/site/twiki/Configuration.twiki 74da49a 
  docs/src/site/twiki/FalconDocumentation.twiki f384a42 
  docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
  docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
  src/conf/startup.properties 1694930 

Diff: https://reviews.apache.org/r/41342/diff/


Testing
-------

Compiled and ensured the html shows up properly on the browser.


Thanks,

Pallavi Rao


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Ajay Yadava <aj...@gmail.com>.

> On Dec. 15, 2015, 4:06 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 76
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162302#file1162302line76>
> >
> >     I believe most production use cases will be on either MySQL or Postgres. Will this script work in those scenaios as well?

We should also document that the expected permissions of the user to run the script(even if it can be run from any user, we should call it out)


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110271
-----------------------------------------------------------


On Dec. 14, 2015, 12:01 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 12:01 p.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Pallavi Rao <pa...@inmobi.com>.

> On Dec. 15, 2015, 4:06 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 10
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162302#file1162302line10>
> >
> >     We should also mention that execution order is not currently supported.

Intended to add support before 0.9. But, anyway, will mention that. Doc can be updated along with feature patch.


> On Dec. 15, 2015, 4:06 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 17
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162302#file1162302line17>
> >
> >     nit: Does it make sense to alter the order of Current capabilities and future road map.

Did that.


> On Dec. 15, 2015, 4:06 a.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 126
> > <https://reviews.apache.org/r/41342/diff/1/?file=1162302#file1162302line126>
> >
> >     how will this command look like if the default scheduler is native?

Added details in the scheduling section. Didn't want to clutter this section.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110271
-----------------------------------------------------------


On Dec. 14, 2015, 12:01 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 12:01 p.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Re: Review Request 41342: FALCON-1652 Documentation for enabling native scheduler in falcon

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41342/#review110271
-----------------------------------------------------------



docs/src/site/twiki/FalconNativeScheduler.twiki (line 10)
<https://reviews.apache.org/r/41342/#comment170212>

    We should also mention that execution order is not currently supported.



docs/src/site/twiki/FalconNativeScheduler.twiki (line 17)
<https://reviews.apache.org/r/41342/#comment170211>

    nit: Does it make sense to alter the order of Current capabilities and future road map.



docs/src/site/twiki/FalconNativeScheduler.twiki (line 25)
<https://reviews.apache.org/r/41342/#comment170219>

    Currently it looks like you need to make these changes only when you need to run native scheduler as default scheduler. 
    We should separate it into two sections:
    * how to enable native scheduler.
    * how to make native scheduler default scheduler



docs/src/site/twiki/FalconNativeScheduler.twiki (line 76)
<https://reviews.apache.org/r/41342/#comment170089>

    I believe most production use cases will be on either MySQL or Postgres. Will this script work in those scenaios as well?



docs/src/site/twiki/FalconNativeScheduler.twiki (line 110)
<https://reviews.apache.org/r/41342/#comment170202>

    



docs/src/site/twiki/FalconNativeScheduler.twiki (line 126)
<https://reviews.apache.org/r/41342/#comment170222>

    how will this command look like if the default scheduler is native?


- Ajay Yadava


On Dec. 14, 2015, 12:01 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41342/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 12:01 p.m.)
> 
> 
> Review request for Falcon and PRAGYA MITTAL.
> 
> 
> Bugs: FALCON-1652
>     https://issues.apache.org/jira/browse/FALCON-1652
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Documentation for enabling native scheduler in falcon
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Configuration.twiki 74da49a 
>   docs/src/site/twiki/FalconDocumentation.twiki f384a42 
>   docs/src/site/twiki/FalconNativeScheduler.twiki PRE-CREATION 
>   docs/src/site/twiki/falconcli/Schedule.twiki 63aa9c1 
>   src/conf/startup.properties 1694930 
> 
> Diff: https://reviews.apache.org/r/41342/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ensured the html shows up properly on the browser.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>