You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/08 11:48:21 UTC

[jira] [Commented] (IGNITE-3221) Bad ip used , when fixed ip in hostname

    [ https://issues.apache.org/jira/browse/IGNITE-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320405#comment-15320405 ] 

ASF GitHub Bot commented on IGNITE-3221:
----------------------------------------

GitHub user sebadiaz opened a pull request:

    https://github.com/apache/ignite/pull/785

    [IGNITE-3221] Bad ip used , when fixed ip in hostname

    The target is to set the ip written in a string format instead to call the DNS to resolve it. 
    
    DNS could not be well working in some case and the IP is the more clear connection that we can make

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sebadiaz/ignite master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #785
    
----
commit 266a2dd9725eaa5251a6fce876745ee4080b3dfb
Author: Sebastien Diaz <se...@misys.com>
Date:   2016-06-08T11:36:47Z

    IGNITE-3221 check IP and convert it

commit 26443bf41e4a8acb031054c5c295be22b6921102
Author: Sebastien Diaz <se...@misys.com>
Date:   2016-06-08T11:37:50Z

    IGNITE-3221 check IP and convert it

commit f3bdc95f8a507d26e6b7ca598a609f77f9609fba
Author: Sebastien Diaz <se...@misys.com>
Date:   2016-06-08T11:39:51Z

    IGNITE-3221 check IP and convert it

commit 0d1091e9ad7b8cee9f1078171a6e8362d8731f1f
Author: Sebastien Diaz <se...@misys.com>
Date:   2016-06-08T11:42:49Z

    IGNITE-3221 check IP and convert it

commit 9f357d020e64b7374d47593bc35dc57d685f87f1
Author: Sebastien Diaz <se...@misys.com>
Date:   2016-06-08T11:43:54Z

    IGNITE-3221 check IP and convert it

----


> Bad ip used , when fixed ip in hostname
> ---------------------------------------
>
>                 Key: IGNITE-3221
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3221
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: sebastien diaz
>            Assignee: Denis Magda
>              Labels: community
>
> Hello
> My machine have certainly a bad dns resolve issue (docker+swarm,network and compose)  but I fix the ip directly at the place of the hostname.
> Unfortunately TcpDiscoveryNode mark a different socker ip
> Example host=40.1.0.23 -> socketAddress=104.239.213.7 :
> TcpDiscoveryNode [id=54b73d98-e702-4660-957a-61d065003078, addrs=[40.1.0.23], sockAddrs=[44de9a1e9afe/104.239.213.7:47500, /40.1.0.23:47500]
> The code apparently in casuse should be :
> public static InetAddress resolveLocalHost(@Nullable String hostName) throws IOException {
>     return F.isEmpty(hostName) ?
>         // Should default to InetAddress#anyLocalAddress which is package-private.
>         new InetSocketAddress(0).getAddress() :
>         InetAddress.getByName(hostName);
> }
> In my issue it will preferable to not use the function
> InetAddress.getByName 
> but to use something as 
> InetAddress.getByAddress(ipAddr);
> thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)