[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9284: Reduce dashboard bootstrap payload

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9284: Reduce dashboard bootstrap payload
URL: https://github.com/apache/incubator-superset/pull/9284#discussion_r391218627
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1788,25 +1788,40 @@ def dashboard(self, dashboard_id):
         dash = qry.one_or_none()
         if not dash:
             abort(404)
-        datasources = set()
+        datasources = {}
 
 Review comment:
   Could we use a `defaultdict(lambda: defaultdict(list))` ? This means the logic in lines 1795 - 1801 could be simplified.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org