You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2016/02/21 15:31:09 UTC

[GitHub] thrift pull request: THRIFT-3650 union (and optionals) serializati...

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/881

    THRIFT-3650 union (and optionals) serialization

    Contains all fixes for THRIFT-3650, 3652, 3654 and 3656 (4 patches) 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3650

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #881
    
----
commit 4606783164233330ae9171ea998cf5c5f9ce9475
Author: Jens Geyer <je...@apache.org>
Date:   2016-02-21T14:07:51Z

    THRIFT-3650 incorrect union serialization Client: Compiler (general) Patch: Jens Geyer

commit beab25cb84ae77692417345dbddadfa65cfca385
Author: Jens Geyer <je...@apache.org>
Date:   2016-02-21T14:14:41Z

    THRIFT-3654 incorrect serialization of optionals Client: Haxe Patch: Jens Geyer

commit 6a1fb354f24e1e48b4767ec8d54bb66ed984555a
Author: Jens Geyer <je...@apache.org>
Date:   2016-02-21T14:19:45Z

    THRIFT-3652 incorrect serialization of optionals Client: AS3 Patch: Jens Geyer

commit 695d5cb7a75f9e2d3625e7c342d6ef5101f5f774
Author: Jens Geyer <je...@apache.org>
Date:   2016-02-21T14:23:37Z

    THRIFT-3656 incorrect serialization of optionals Client: Dart Patch: Jens Geyer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3650 union (and optionals) serializati...

Posted by markerickson-wf <gi...@git.apache.org>.
Github user markerickson-wf commented on the pull request:

    https://github.com/apache/thrift/pull/881#issuecomment-186842383
  
    +1 on the Dart fix, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3650 union (and optionals) serializati...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/881


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---