You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/11 14:47:55 UTC
[GitHub] [incubator-zipkin-brave] adriancole commented on issue #908: Fixes
some edge cases around sampler resetting
adriancole commented on issue #908: Fixes some edge cases around sampler resetting
URL: https://github.com/apache/incubator-zipkin-brave/pull/908#issuecomment-491516989
I used https://github.com/adriancole/zipkin-voltdb to integration test this and sent 4 bursts of 10 seconds of 3K+ requests/second. Using a throttled rate of 20/second it ended up quite close to correct (778 instead of 800). Note most of the gap seems warmup related and I don't completely understand that. Ex the last burst had 196 traces (20/second * 10 seconds) so quite close.
(note: this is based on export/tail sampling.. we should probably bundle this in zipkin lib so we don't have to copy/paste for collectors to use it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org