[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11777: Refactor LogServiceClient Singleton to avoid repeat creation of NettyClient

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #11777:
URL: https://github.com/apache/dolphinscheduler/pull/11777#discussion_r969067074


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractRemoteTask.java:
##########
@@ -38,7 +38,7 @@ public void cancel() throws TaskException {
         this.cancelApplication();
     }
 
-    public abstract Set<String> getApplicationIds() throws TaskException;
+    public abstract List<String> getApplicationIds() throws TaskException;

Review Comment:
   Why to replace Set with List? The appIds should not be repeat.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org