You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/02/24 13:16:12 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #1975] [BUILD] Run TPC-DS test using the default Spark version

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 3cbedea  [KYUUBI #1975] [BUILD] Run TPC-DS test using the default Spark version
3cbedea is described below

commit 3cbedea7d685183966c84b0dc97a86b78d2627b6
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Thu Feb 24 21:16:02 2022 +0800

    [KYUUBI #1975] [BUILD] Run TPC-DS test using the default Spark version
    
    ### _Why are the changes needed?_
    
    Use the default Spark version to run TPC-DS test.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1975 from pan3793/tpcds.
    
    Closes #1975
    
    ecdda1d9 [Cheng Pan] style
    1e8468f4 [Cheng Pan] nit
    9666cd8b [Cheng Pan] Update golden file
    10b38939 [Cheng Pan] default spark version
    c1c9b037 [Cheng Pan] [BUILD] Run TPC-DS test using Spark 3.2
    
    Authored-by: Cheng Pan <ch...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .github/workflows/master.yml                                      | 1 -
 kyuubi-server/src/test/resources/tpcds-1_4/q61/q61.output.schema  | 2 +-
 .../apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala    | 8 ++++++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index 6f56989..d3a9459 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -116,7 +116,6 @@ jobs:
         run: >-
           ./build/mvn clean install -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -V
           -pl kyuubi-server -am
-          -Pspark-3.1
           -Dmaven.plugin.scalatest.exclude.tags=''
           -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds
 
diff --git a/kyuubi-server/src/test/resources/tpcds-1_4/q61/q61.output.schema b/kyuubi-server/src/test/resources/tpcds-1_4/q61/q61.output.schema
index 6959406..f9e8b1a 100644
--- a/kyuubi-server/src/test/resources/tpcds-1_4/q61/q61.output.schema
+++ b/kyuubi-server/src/test/resources/tpcds-1_4/q61/q61.output.schema
@@ -1 +1 @@
-struct<promotions:decimal,total:decimal,(CAST((CAST(CAST(promotions AS DECIMAL(15,4)) AS DECIMAL(15,4)) / CAST(CAST(total AS DECIMAL(15,4)) AS DECIMAL(15,4))) AS DECIMAL(35,20)) * CAST(CAST(100 AS DECIMAL(3,0)) AS DECIMAL(35,20))):decimal>
+struct<promotions:decimal,total:decimal,((CAST(promotions AS DECIMAL(15,4)) / CAST(total AS DECIMAL(15,4))) * 100):decimal>
diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala
index 6d69f83..ec2ecc4 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala
@@ -29,12 +29,16 @@ import org.apache.kyuubi.tags.{DeltaTest, ExtendedSQLTest}
 /**
  * To run this test suite:
  * {{{
- *   build/mvn clean install -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
+ *   build/mvn clean install \
+ *     -Dmaven.plugin.scalatest.exclude.tags="" \
+ *     -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
  * }}}
  *
  * To re-generate golden files for this suite:
  * {{{
- *   KYUUBI_UPDATE=1 build/mvn clean install -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
+ *   KYUUBI_UPDATE=1 build/mvn clean install \
+ *     -Dmaven.plugin.scalatest.exclude.tags="" \
+ *     -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
  * }}}
  */
 // scalastyle:on line.size.limit