You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/25 19:03:51 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5850: armv7-m/armv8-m: more pref to common place
anchao opened a new pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850
## Summary
armv7-m/armv8-m: more pref to common place
## Impact
N/A
## Testing
CI check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5850: armv7-m/armv8-m: move up_pref* api to common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850#discussion_r835754822
##########
File path: include/nuttx/arch.h
##########
@@ -2555,8 +2555,10 @@ void arch_sporadic_resume(FAR struct tcb_s *tcb);
*
* The second interface simple converts an elapsed time into well known
* units.
+ *
****************************************************************************/
+void up_perf_init(FAR void *arg);
Review comment:
It intend to use void * here, if other arch implementation may need more argument, he can define a struct to contain more info without modify the prototype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5850: armv7-m/armv8-m: move up_pref* api to common place
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850#discussion_r835755077
##########
File path: include/nuttx/arch.h
##########
@@ -2555,8 +2555,10 @@ void arch_sporadic_resume(FAR struct tcb_s *tcb);
*
* The second interface simple converts an elapsed time into well known
* units.
+ *
****************************************************************************/
+void up_perf_init(FAR void *arg);
Review comment:
`uintptr_t` will give same effect. But let's keep `void *`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5850: armv7-m/armv8-m: move up_pref* api to common place
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850#discussion_r835754500
##########
File path: include/nuttx/arch.h
##########
@@ -2555,8 +2555,10 @@ void arch_sporadic_resume(FAR struct tcb_s *tcb);
*
* The second interface simple converts an elapsed time into well known
* units.
+ *
****************************************************************************/
+void up_perf_init(FAR void *arg);
Review comment:
Just feedback if you will apply suggestion, so I can either wait for update or merge it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5850: armv7-m/armv8-m: move up_pref* api to common place
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850#discussion_r835754161
##########
File path: include/nuttx/arch.h
##########
@@ -2555,8 +2555,10 @@ void arch_sporadic_resume(FAR struct tcb_s *tcb);
*
* The second interface simple converts an elapsed time into well known
* units.
+ *
****************************************************************************/
+void up_perf_init(FAR void *arg);
Review comment:
```suggestion
void up_perf_init(uintptr_t arg);
```
Just an option to have less type casts.
I'm fine with current way.
Or we can make it more explicit `void up_perf_init(uint32_t cpu_freq);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5850: armv7-m/armv8-m: move up_pref* api to common place
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5850:
URL: https://github.com/apache/incubator-nuttx/pull/5850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org