[GitHub] [iceberg] wmoustafa commented on a change in pull request #2496: [#2039] Support default value semantics - API changes

[GitBox <gi...@apache.org>]

wmoustafa commented on a change in pull request #2496:
URL: https://github.com/apache/iceberg/pull/2496#discussion_r810304229



##########
File path: site/docs/spec.md
##########
@@ -159,6 +161,13 @@ A **`list`** is a collection of values with some element type. The element field
 
 A **`map`** is a collection of key-value pairs with a key type and a value type. Both the key field and value field each have an integer id that is unique in the table schema. Map keys are required and map values can be either optional or required. Both map keys and map values may be any type, including nested types.
 
+Iceberg supports default-value semantics for fields of nested types (i.e., struct, list and map). Specifically, a field 

Review comment:
       The intention here is to provide default values for map, array, and struct fields, not the building blocks of those types (e.g., map keys, map values, or array elements). Not sure if this addresses Ryan's concern, but I think it is reasonable (and in our internal case required) to provide default values for fields of such data types. Pre-set default values (e.g., empty list or map) may not suit all use cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org