You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/20 09:53:51 UTC

[GitHub] [bookkeeper] Sunny-Island edited a comment on pull request #2742: Abstract the FileChannel in the JournalChannel

Sunny-Island edited a comment on pull request #2742:
URL: https://github.com/apache/bookkeeper/pull/2742#issuecomment-902567598


   `FileChannelProvider ` do not hold any resources, maybe you mean add `close() `to BookieFileChannel? `close()` method can release `RandomAccessFile` and its `FileChannel` @eolivelli .
   Also, I guess I need to add test to ensure DefaultFileChannel methods are invoked in the correct sequence?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org