You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/18 09:21:47 UTC

[GitHub] [kylin] codecov-io commented on issue #757: KYLIN-3917: Add max segment merge span to cleanup intermediate data of cube building

codecov-io commented on issue #757: KYLIN-3917: Add max segment merge span to cleanup intermediate data of cube building
URL: https://github.com/apache/kylin/pull/757#issuecomment-512737154
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=h1) Report
   > Merging [#757](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/8b3a2685369ce24366c2caca2039c3a450723c58?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/757/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #757      +/-   ##
   ===========================================
   - Coverage     25.72%   25.7%   -0.02%     
   + Complexity     6022    6020       -2     
   ===========================================
     Files          1387    1387              
     Lines         82770   82795      +25     
     Branches      11588   11594       +6     
   ===========================================
   - Hits          21290   21286       -4     
   - Misses        59435   59460      +25     
   - Partials       2045    2049       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `37.45% <0%> (-0.32%)` | `44 <0> (ø)` | |
   | [...java/org/apache/kylin/metadata/model/Segments.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvU2VnbWVudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.88% <0%> (-0.02%)` | `42 <0> (ø)` | |
   | [...a/org/apache/kylin/rest/job/StorageCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbnVwSm9iLmphdmE=) | `64.28% <57.14%> (-0.68%)` | `31 <0> (ø)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=footer). Last update [8b3a268...270af01](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services