You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/18 07:03:53 UTC
[PR] [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*` [spark]
zhengruifeng opened a new pull request, #45559:
URL: https://github.com/apache/spark/pull/45559
### What changes were proposed in this pull request?
Correct the error class for `DataFrame.sort*`
### Why are the changes needed?
`DataFrame.sort*` support negative indices, which means `sort by desc`
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45559: [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*`
URL: https://github.com/apache/spark/pull/45559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #45559:
URL: https://github.com/apache/spark/pull/45559#discussion_r1528014246
##########
python/pyspark/errors/error_classes.py:
##########
@@ -347,6 +347,11 @@
"Index must be positive, got '<index>'."
]
},
+ "INDEX_NOT_ZERO": {
Review Comment:
I am fine with `ZERO_INDEX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45559:
URL: https://github.com/apache/spark/pull/45559#discussion_r1527966487
##########
python/pyspark/errors/error_classes.py:
##########
@@ -347,6 +347,11 @@
"Index must be positive, got '<index>'."
]
},
+ "INDEX_NOT_ZERO": {
Review Comment:
The error class should tell about the issue not solution, IMHO. Could you rename it to: `ZERO_INDEX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47437][PYTHON][CONNECT] Correct the error class for `DataFrame.sort*` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45559:
URL: https://github.com/apache/spark/pull/45559#issuecomment-2003655068
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org