You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/30 02:55:45 UTC

[GitHub] [pulsar] tuteng commented on issue #3941: [Issue 3837][pulsar-client-tools]Delete schema when deleting a topic

tuteng commented on issue #3941: [Issue 3837][pulsar-client-tools]Delete schema when deleting a topic
URL: https://github.com/apache/pulsar/pull/3941#issuecomment-478199935
 
 
   > @tuteng
   > 
   > overall looks good. can you try to add a test for it?
   > 
   > you can check `pulsar-client-tools-test` to see how we test `CmdFunctions`.
   
   I did not find the relevant test in `CmdFunctions`, but i added the relevant tests in `PulsarAdminToolTest`. Please review the code again, thanks. @sijie 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services