You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2011/10/21 01:41:11 UTC
svn commit: r1187134 - in
/incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity:
GeneralizationListReducerTest.java LemmaFormManagerTest.java
Author: joern
Date: Thu Oct 20 23:41:11 2011
New Revision: 1187134
URL: http://svn.apache.org/viewvc?rev=1187134&view=rev
Log:
OPENNLP-330 Fixed junit tests, so they work with opennlp 1.5.2. Thanks to Boris Galitsky for providing a patch.
Modified:
incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/GeneralizationListReducerTest.java
incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/LemmaFormManagerTest.java
Modified: incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/GeneralizationListReducerTest.java
URL: http://svn.apache.org/viewvc/incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/GeneralizationListReducerTest.java?rev=1187134&r1=1187133&r2=1187134&view=diff
==============================================================================
--- incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/GeneralizationListReducerTest.java (original)
+++ incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/GeneralizationListReducerTest.java Thu Oct 20 23:41:11 2011
@@ -17,16 +17,11 @@
package opennlp.tools.textsimilarity;
-import static junit.framework.Assert.assertNotNull;
-
import java.util.ArrayList;
import java.util.List;
import junit.framework.TestCase;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-
public class GeneralizationListReducerTest extends TestCase{
private GeneralizationListReducer generalizationListReducer = new GeneralizationListReducer();
@@ -63,9 +58,15 @@ public class GeneralizationListReducerTe
inp.add(ch4);
assertTrue(ch1.isASubChunk(ch2));
- assertTrue(ch2.isASubChunk(ch1));
- assertTrue(ch5.isASubChunk(ch4));
+ assertFalse(ch2.isASubChunk(ch1));
+ assertFalse(ch5.isASubChunk(ch4));
assertTrue(ch4.isASubChunk(ch5));
+
+ assertFalse(ch2.isASubChunk(ch3));
+ assertFalse(ch3.isASubChunk(ch2));
+
+ assertFalse(ch5.isASubChunk(ch3));
+ assertFalse(ch3.isASubChunk(ch5));
List<ParseTreeChunk> res = generalizationListReducer
.applyFilteringBySubsumption(inp);
Modified: incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/LemmaFormManagerTest.java
URL: http://svn.apache.org/viewvc/incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/LemmaFormManagerTest.java?rev=1187134&r1=1187133&r2=1187134&view=diff
==============================================================================
--- incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/LemmaFormManagerTest.java (original)
+++ incubator/opennlp/sandbox/opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/LemmaFormManagerTest.java Thu Oct 20 23:41:11 2011
@@ -18,30 +18,28 @@
package opennlp.tools.textsimilarity;
import static junit.framework.Assert.assertNotNull;
+import junit.framework.TestCase;
import org.junit.Test;
import org.junit.runner.RunWith;
-public class LemmaFormManagerTest {
+public class LemmaFormManagerTest extends TestCase{
- private LemmaFormManager lemmaFormManager;
+ private LemmaFormManager lemmaFormManager = new LemmaFormManager();
- public void notNullTest() {
+ public void testNotNull() {
assertNotNull(lemmaFormManager);
}
- public void matchesTest() {
-
- String res = lemmaFormManager.matchLemmas(null, "loud", "loudness", "NN");
- res = lemmaFormManager.matchLemmas(null, "24", "12", "CD");
-
- res = lemmaFormManager.matchLemmas(null, "loud", "loudly", "NN");
- res = lemmaFormManager.matchLemmas(null, "!upgrade", "upgrade", "NN");
- res = lemmaFormManager.matchLemmas(null, "!upgrade", "upgrades", "NN");
- res = lemmaFormManager.matchLemmas(null, "!upgrade", "get", "NN");
-
+ public void testMatches() {
+ assertEquals(lemmaFormManager.matchLemmas(null, "loud", "loudness", "NN"), "loud" );
+ assertEquals(lemmaFormManager.matchLemmas(null, "24", "12", "CD"), null);
+ assertEquals(lemmaFormManager.matchLemmas(null, "loud", "loudly", "NN"), "loud" );
+ assertEquals(lemmaFormManager.matchLemmas(null, "!upgrade", "upgrade", "NN"), "!upgrade" );
+ assertEquals(lemmaFormManager.matchLemmas(null, "!upgrade", "upgrades", "NN"), null );
+ assertEquals(lemmaFormManager.matchLemmas(null, "!upgrade", "get", "NN"), null);
}
}