You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/07 11:46:50 UTC
[GitHub] [hudi] nsivabalan commented on a change in pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
nsivabalan commented on a change in pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#discussion_r800575366
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -101,24 +101,31 @@ public S3EventsHoodieIncrSource(
? lastCkptStr.get().isEmpty() ? Option.empty() : lastCkptStr
: Option.empty();
- Pair<String, String> instantEndpts =
+ Pair<String, Pair<String, String>> queryTypeAndInstantEndpts =
IncrSourceHelper.calculateBeginAndEndInstants(
sparkContext, srcPath, numInstantsPerFetch, beginInstant, missingCheckpointStrategy);
- if (instantEndpts.getKey().equals(instantEndpts.getValue())) {
- LOG.warn("Already caught up. Begin Checkpoint was :" + instantEndpts.getKey());
- return Pair.of(Option.empty(), instantEndpts.getKey());
+ if (queryTypeAndInstantEndpts.getValue().getKey().equals(queryTypeAndInstantEndpts.getValue().getValue())) {
+ LOG.warn("Already caught up. Begin Checkpoint was :" + queryTypeAndInstantEndpts.getKey());
+ return Pair.of(Option.empty(), queryTypeAndInstantEndpts.getKey());
}
+ DataFrameReader metaReader = null;
// Do incremental pull. Set end instant if available.
- DataFrameReader metaReader = sparkSession.read().format("org.apache.hudi")
- .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
- .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), instantEndpts.getLeft())
- .option(DataSourceReadOptions.END_INSTANTTIME().key(), instantEndpts.getRight());
+ if (queryTypeAndInstantEndpts.getKey().equals(DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())) {
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
+ .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getLeft())
+ .option(DataSourceReadOptions.END_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getRight());
+ } else {
+ // if checkpoint is missing from source table, and if strategy is set to READ_UPTO_LATEST_COMMIT, we have to issue snapshot query
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_SNAPSHOT_OPT_VAL());
Review comment:
fixing this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org