You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/08/18 06:16:40 UTC
[kudu-CR] [thirdparty] fix boost build with clang from Xcode
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14089
Change subject: [thirdparty] fix boost build with clang from Xcode
......................................................................
[thirdparty] fix boost build with clang from Xcode
The clang version string in Xcode (see [1]) uses slightly different
format than clang built via MacPorts/Homebrew or clang on various
Linux flavors. This patch adapts the build_boost() function to work
with clang from Xcode.
[1] https://gist.github.com/yamaya/2924292
Change-Id: I082af11af012cfb80a89ddb5ddf638100eb74574
---
M thirdparty/build-definitions.sh
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/14089/1
--
To view, visit http://gerrit.cloudera.org:8080/14089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I082af11af012cfb80a89ddb5ddf638100eb74574
Gerrit-Change-Number: 14089
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] fix boost build with clang from Xcode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14089 )
Change subject: [thirdparty] fix boost build with clang from Xcode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082af11af012cfb80a89ddb5ddf638100eb74574
Gerrit-Change-Number: 14089
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Aug 2019 03:51:42 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix boost build with clang from Xcode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14089 )
Change subject: [thirdparty] fix boost build with clang from Xcode
......................................................................
[thirdparty] fix boost build with clang from Xcode
The clang version string in Xcode (see [1]) uses slightly different
format than clang built via MacPorts/Homebrew or clang on various
Linux flavors. This patch adapts the build_boost() function to work
with clang from Xcode.
[1] https://gist.github.com/yamaya/2924292
Change-Id: I082af11af012cfb80a89ddb5ddf638100eb74574
Reviewed-on: http://gerrit.cloudera.org:8080/14089
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/build-definitions.sh
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I082af11af012cfb80a89ddb5ddf638100eb74574
Gerrit-Change-Number: 14089
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)