You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/10/16 22:35:11 UTC

[commons-io] 04/06: Add a factory method and move test class to proper package.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git

commit 683590f0a0fbb83d03e4b97813cbf2e302f4283d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 16 18:30:22 2020 -0400

    Add a factory method and move test class to proper package.
---
 .../java/org/apache/commons/io/file/PathUtils.java | 12 +++++++++++
 .../io/{ => file}/DirectoryStreamFilterTest.java   |  4 +++-
 .../org/apache/commons/io/file/PathUtilsTest.java  | 23 +++++++++++++++++++---
 3 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/io/file/PathUtils.java b/src/main/java/org/apache/commons/io/file/PathUtils.java
index 74cb8ae..c654f35 100644
--- a/src/main/java/org/apache/commons/io/file/PathUtils.java
+++ b/src/main/java/org/apache/commons/io/file/PathUtils.java
@@ -678,6 +678,18 @@ public final class PathUtils {
     }
 
     /**
+     * Creates a new DirectoryStream for Paths rooted at the given directory.
+     * 
+     * @param dir the path to the directory to stream.
+     * @param pathFilter the directory stream filter.
+     * @return a new instance.
+     * @throws IOException if an I/O error occurs.
+     */
+    public static DirectoryStream<Path> newDirectoryStream(final Path dir, PathFilter pathFilter) throws IOException {
+        return Files.newDirectoryStream(dir, new DirectoryStreamFilter(pathFilter));
+    }
+
+    /**
      * Returns true if the given options contain {@link StandardDeleteOption#OVERRIDE_READ_ONLY}.
      *
      * @param options the array to test
diff --git a/src/test/java/org/apache/commons/io/DirectoryStreamFilterTest.java b/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java
similarity index 97%
rename from src/test/java/org/apache/commons/io/DirectoryStreamFilterTest.java
rename to src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java
index a337f6f..1f84557 100644
--- a/src/test/java/org/apache/commons/io/DirectoryStreamFilterTest.java
+++ b/src/test/java/org/apache/commons/io/file/DirectoryStreamFilterTest.java
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.commons.io;
+package org.apache.commons.io.file;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -29,6 +29,7 @@ import java.util.Iterator;
 
 import org.apache.commons.io.file.DirectoryStreamFilter;
 import org.apache.commons.io.file.PathFilter;
+import org.apache.commons.io.file.PathUtils;
 import org.apache.commons.io.filefilter.NameFileFilter;
 import org.junit.jupiter.api.Test;
 
@@ -63,4 +64,5 @@ public class DirectoryStreamFilterTest {
             }
         }
     }
+
 }
diff --git a/src/test/java/org/apache/commons/io/file/PathUtilsTest.java b/src/test/java/org/apache/commons/io/file/PathUtilsTest.java
index d1e3823..c76c5d2 100644
--- a/src/test/java/org/apache/commons/io/file/PathUtilsTest.java
+++ b/src/test/java/org/apache/commons/io/file/PathUtilsTest.java
@@ -18,24 +18,30 @@
 package org.apache.commons.io.file;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.IOException;
+import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.util.Iterator;
 
+import org.apache.commons.io.filefilter.NameFileFilter;
 import org.junit.jupiter.api.Test;
 
 public class PathUtilsTest extends TestArguments {
 
+    private static final String PATH_FIXTURE = "NOTICE.txt";
+
     @Test
     public void testCopyFile() throws IOException {
         final Path tempDir = Files.createTempDirectory(getClass().getCanonicalName());
         try {
-            final Path sourceFile = Paths.get("src/test/resources/org/apache/commons/io/dirs-1-file-size-1/file-size-1.bin");
-            final Path targetFile = PathUtils.copyFileToDirectory(
-                    sourceFile, tempDir);
+            final Path sourceFile = Paths
+                .get("src/test/resources/org/apache/commons/io/dirs-1-file-size-1/file-size-1.bin");
+            final Path targetFile = PathUtils.copyFileToDirectory(sourceFile, tempDir);
             assertTrue(Files.exists(targetFile));
             assertEquals(Files.size(sourceFile), Files.size(targetFile));
         } finally {
@@ -43,4 +49,15 @@ public class PathUtilsTest extends TestArguments {
         }
     }
 
+    @Test
+    public void testNewDirectoryStream() throws Exception {
+        final PathFilter pathFilter = new NameFileFilter(PATH_FIXTURE);
+        try (final DirectoryStream<Path> stream = PathUtils.newDirectoryStream(Paths.get("."), pathFilter)) {
+            final Iterator<Path> iterator = stream.iterator();
+            final Path path = iterator.next();
+            assertEquals(PATH_FIXTURE, path.getFileName().toString());
+            assertFalse(iterator.hasNext());
+        }
+    }
+
 }